Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws eks update-kubeconfig does not support external_id #4053

Open
benderillo opened this issue Apr 5, 2019 · 11 comments
Open

aws eks update-kubeconfig does not support external_id #4053

benderillo opened this issue Apr 5, 2019 · 11 comments
Labels
eks-kubeconfig feature-request A feature should be added or improved. p2 This is a standard priority issue

Comments

@benderillo
Copy link

There is no way at the moment to specify external_id when calling aws eks update-kubeconfig.

It supports specifying role-arn for the case when the cluster was created with assumed role.
However, if the role has an extra condition like: StringEquals | sts:ExternalId | test_account there is no way to supply aws eks update-kubeconfig this info.

It seems that the problem is even wider, I do not see support fo external_id in aws-iam-authenticator token either.

Basically, here is the use case:
We use terraform with assumed role (that has external_id condition set) to bring up EKS cluster and worker nodes.

In order to finish the setup, we need to do kubectl apply of the ConfigMap with AWS Auth to let nodes join the cluster.
In order to do so, we first need to prepare .kubeconfig that will use the same role, that terraform assumed to create the cluster.

Unfortunately, there is no way to specify external_id there and attempts to execute kubectl apply fail with

could not get token: AccessDenied: Access denied
	status code: 403, request id: xxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxx

To sum up, this issue is a feature request to add ability to specify external_id when providing role-arn to aws eks update-kubeconfig.

I am not sure how to go about highlighting the same problem to aws-iam-authenticator though.

@justnance justnance self-assigned this Apr 22, 2019
@justnance justnance added dependencies This issue is a problem in a dependency. feature-request A feature should be added or improved. labels Apr 22, 2019
@justnance
Copy link

justnance commented Apr 22, 2019

@benderillo - Thank you for your post. For the CLI to support external_id in aws eks update-kubeconfig, this feature would have to be implemented in both the aws-iam-authenticator token and aws-iam-authenticator server before it can implemented in the CLI.

As to highlighting the same problem to aws-iam-authenticator, you can reach out to the GitHub repository for the authenticator.

Marked this issue as a feature request with a dependency but closing it because the authenticator does not support it at this time.

@benderillo
Copy link
Author

@justnance What do I do to re-open the issue? It seems the authenticator has added support for external_id here: kubernetes-sigs/aws-iam-authenticator#228
It is in merged state at the moment.

@benderillo
Copy link
Author

I am glad to see this re-open. Hopefully, we can get this implemented in some not so distant future, the future where the world will have become a bit better place because external-id is finally supported :)

@github-actions
Copy link

Greetings! It looks like this issue hasn’t been active in longer than one year. We encourage you to check if this is still an issue in the latest release. In the absence of more information, we will be closing this issue soon. If you find that this is still a problem, please feel free to provide a comment or upvote with a reaction on the initial post to prevent automatic closure. If the issue is already closed, please feel free to open a new one.

@github-actions github-actions bot added closing-soon This issue will automatically close in 4 days unless further comments are made. closed-for-staleness and removed closing-soon This issue will automatically close in 4 days unless further comments are made. labels Sep 25, 2021
@VishalAgarW
Copy link

Is this issue actually fixed, I still don't see option to pass external id?

@kahirokunn
Copy link

I need this feature.

@benderillo
Copy link
Author

@justnance and @kdaily Is there a way to reopen this ticket if external id is still not supported?
Since authenticator supports this flag, perhaps nothing now precludes supporting it in aws eks?

To make it very clear, this request is to add a new optional parameter to aws eks update-kubeconfig like --external-id/-e that allows to pass external id.
Since authenticator now supports similar flag, I don't see why it can't be added to CLI.

/open
/reopen

@kahirokunn
Copy link

I am of the same opinion.

@tim-finnigan
Copy link
Contributor

tim-finnigan commented Apr 5, 2023

Reopening issue for further review

@kahirokunn
Copy link

I took the initiative to create a PR because I want to solve your problems.
#7879

@kahirokunn
Copy link

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
eks-kubeconfig feature-request A feature should be added or improved. p2 This is a standard priority issue
Projects
None yet
Development

No branches or pull requests

6 participants