Explicitly translate supported confi values to TransferConfig #2146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. 🚢 assuming test pass. |
The previous implementation made the open-ended assumption that runtime config translates 1-1 to transfer configs. This also had the (unintended) side effect that everything in transfer config was implicitly supported in the ~/.aws/config file because the config is passed directly to `TransferConfig`. I've updated the code to have a fixed list of supported config values. This means that we need to explicitly update this list as we decide to support for transfer config options.
jamesls
force-pushed
the
streams-config-fix
branch
from
864936e to
777b0aa
Compare
|
Ok I've branched off of develop and set develop as the base branch. |
|
Still 🚢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation made the open-ended assumption that
runtime config translates 1-1 to transfer configs.
This also had the (unintended) side effect that everything in
transfer config was implicitly supported in the ~/.aws/config
file because the config is passed directly to
TransferConfig.This also generates errors if you pass an unknown option to the
TransferConfig, both for nonsensical values as well as validvalues supported in
~/.aws/configbut not inTransferConfig.I noticed this because I had
addressing_style=pathin my
~/.aws/configfile:I've updated the code to have a fixed list of supported config values.
This means that we need to explicitly update this list as we decide
to support for transfer config options.
cc @kyleknap @JordonPhillips