Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable paramfile for sqs purge-queue #1126

Merged
merged 3 commits into from
Feb 6, 2015
Merged

Disable paramfile for sqs purge-queue #1126

merged 3 commits into from
Feb 6, 2015

Conversation

jamesls
Copy link
Member

@jamesls jamesls commented Feb 4, 2015

Valid values for this param will be https so we need to disable paramfile processing.

cc @kyleknap @danielgtaylor

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 91.76% when pulling 4d9c2b6 on jamesls:sqs-purge-queue-fix into 7350250 on aws:develop.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.13%) to 91.62% when pulling 18f33c2 on jamesls:sqs-purge-queue-fix into 7350250 on aws:develop.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 91.76% when pulling 18f33c2 on jamesls:sqs-purge-queue-fix into 7350250 on aws:develop.

@jamesls
Copy link
Member Author

jamesls commented Feb 4, 2015

Coveralls makes no sense here. I think I should be ok test coverage, I added a test for this.

@kyleknap
Copy link
Contributor

kyleknap commented Feb 4, 2015

Yeah its fine. 🚢

@jamesls jamesls merged commit 18f33c2 into aws:develop Feb 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jamesls @coveralls @kyleknap