Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): invalid error when stack name fails validation #4745

Merged
merged 4 commits into from
Nov 17, 2019
Merged

fix(core): invalid error when stack name fails validation #4745

merged 4 commits into from
Nov 17, 2019

Conversation

deepkarang
Copy link
Contributor

@deepkarang deepkarang commented Oct 29, 2019 •
edited by eladb
Loading

Fixing the Invalid Regex error message in lib/stack.ts. Had me debugging the wrong thing for a while since the error message says that a different parameter is violating the regex constraints than the actual one that is (the stack name). Extremely simple fix so don't need to add tests or update ReadMe. (This is how it should've been in the first place).

Fixes #5029

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@deepkarang
Update stack.ts
5930275 
Fixing the Invalid Regex error message. Had me debugging the wrong thing for a while.
@mergify
Copy link
Contributor

mergify bot commented Oct 29, 2019

Thanks so much for taking the time to contribute to the AWS CDK ❤️

We will shortly assign someone to review this pull request and help get it
merged. In the meantime, please take a minute to make sure you follow this
checklist:

  • PR title type(scope): text
    • type: fix, feat, refactor go into CHANGELOG, chore is hidden
    • scope: name of module without aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
    • text: use all lower-case, do not end with a period, do not include issue refs
  • PR Description
    • Rationale: describe rationale of change and approach taken
    • Issues: indicate issues fixed via: fixes #xxx or closes #xxx
    • Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
  • Testing
    • Unit test added. Prefer to add a new test rather than modify existing tests
    • CLI or init templates change? Re-run/add CLI integration tests
  • Documentation
    • README: update module README to describe new features
    • API docs: public APIs must be documented. Copy from official AWS docs when possible
    • Design: for significant features, follow design process

@deepkarang deepkarang changed the title Update stack.ts Fixing Invalid Regex error message to notify user of correct Source of Error Oct 29, 2019
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

eladb
eladb previously requested changes Nov 4, 2019
View reviewed changes
Copy link
Contributor

@eladb eladb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

Can you please go over the PR checklist and make sure you follow it?

@deepkarang deepkarang changed the title Fixing Invalid Regex error message to notify user of correct Source of Error fix(core): Modifying Invalid Regex error message to notify user of correct Source of Error Nov 14, 2019
@deepkarang
Copy link
Contributor Author

@eladb No worries! I hope it's good now? Is there anything else you need me to add?

@mergify mergify bot dismissed eladb’s stale review November 14, 2019 00:08

Pull request has been modified.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@eladb eladb changed the title fix(core): Modifying Invalid Regex error message to notify user of correct Source of Error fix(core): invalid error when stack name fails validation Nov 17, 2019
@mergify
Copy link
Contributor

mergify bot commented Nov 17, 2019

Thank you for contributing! Your pull request is now being automatically merged.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 8fd939d into aws:master Nov 17, 2019
@eladb eladb mentioned this pull request Nov 17, 2019
Closed
@khushail khushail mentioned this pull request Sep 18, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eladb eladb eladb approved these changes

Assignees

@eladb eladb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nested stack validation incorrect
3 participants
@deepkarang @aws-cdk-automation @eladb