Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(apprunner): support vpc ingress connection #30623

Merged
merged 14 commits into from
Oct 30, 2024
Merged

feat(apprunner): support vpc ingress connection #30623

merged 14 commits into from
Oct 30, 2024

Conversation

mazyu36
Copy link
Contributor

@mazyu36 mazyu36 commented Jun 22, 2024

Issue # (if applicable)

Closes #22850.

Reason for this change

To support VPC Ingress Connection for making App Runner Service private and only accessible from within a VPC.

Description of changes

  • Add isPubliclyAccessible property to the Service class
  • Add VpcIngressConnection class

Description of how you validated changes

Add unit tests and integ tests

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added star-contributor [Pilot] contributed between 25-49 PRs to the CDK effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2 labels Jun 22, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team June 22, 2024 09:07
@mazyu36 mazyu36 force-pushed the apprunner-private-access-22850 branch from 5b3e3e1 to 6e66ff9 Compare June 22, 2024 09:59
@mazyu36 mazyu36 marked this pull request as ready for review June 25, 2024 00:16
@mazyu36
Copy link
Contributor Author

mazyu36 commented Jun 25, 2024

@Mergifyio update

@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 25, 2024

update

☑️ Nothing to do

  • #commits-behind>0 [📌 update requirement]
  • -closed [📌 update requirement]
  • -conflict [📌 update requirement]
  • queue-position=-1 [📌 update requirement]

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jun 26, 2024
@github-actions github-actions bot mentioned this pull request Jul 1, 2024
Closed
lpizzinidev
lpizzinidev suggested changes Jul 31, 2024
View reviewed changes
packages/@aws-cdk/aws-apprunner-alpha/README.md Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-apprunner-alpha/lib/vpc-ingress-connection.ts

public constructor(scope: Construct, id: string, props: VpcIngressConnectionProps) {
super(scope, id, {
physicalName: props.vpcIngressConnectionName,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you check if it deploys with vpcIngressConnectionName: undefined?
If not, we should lazily generate one.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I tried deploying with vpcIngressConnectionName: undefined, and I was able to deploy without any issues.

image image

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jul 31, 2024
@mazyu36
Copy link
Contributor Author

mazyu36 commented Jul 31, 2024

@lpizzinidev
Thanks.
I've addressed your comments.

@mazyu36 mazyu36 requested a review from lpizzinidev July 31, 2024 16:10
lpizzinidev
lpizzinidev approved these changes Aug 1, 2024
View reviewed changes
Copy link
Contributor

@lpizzinidev lpizzinidev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Aug 1, 2024
@shikha372 shikha372 self-assigned this Aug 23, 2024
@paulhcsun paulhcsun assigned paulhcsun and unassigned shikha372 Aug 26, 2024
paulhcsun
paulhcsun previously requested changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@paulhcsun paulhcsun left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Design overall looks good, just have a couple questions below.

packages/@aws-cdk/aws-apprunner-alpha/lib/vpc-ingress-connection.ts Show resolved Hide resolved
packages/@aws-cdk/aws-apprunner-alpha/lib/vpc-ingress-connection.ts Show resolved Hide resolved
packages/@aws-cdk/aws-apprunner-alpha/lib/service.ts Outdated Show resolved Hide resolved
@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Oct 29, 2024
@mergify mergify bot dismissed paulhcsun’s stale review October 29, 2024 00:49

Pull request has been modified.

@mazyu36
Copy link
Contributor Author

mazyu36 commented Oct 29, 2024

@paulhcsun
Thank you for the review!
I've addressed the comments.

@mazyu36 mazyu36 requested a review from paulhcsun October 29, 2024 01:00
@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Oct 29, 2024
paulhcsun
paulhcsun approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@paulhcsun paulhcsun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @mazyu36! Thanks for reviewing @lpizzinidev!

@paulhcsun
Copy link
Contributor

@Mergifyio update

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 30, 2024

update

✅ Branch has been successfully updated

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 30, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Oct 30, 2024
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 0dd75ad
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 048e753 into aws:main Oct 30, 2024
15 checks passed
@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 30, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@github-actions GitHub Actions
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 30, 2024
@mazyu36 mazyu36 deleted the apprunner-private-access-22850 branch October 31, 2024 08:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paulhcsun paulhcsun paulhcsun approved these changes

@lpizzinidev lpizzinidev lpizzinidev approved these changes

Assignees

@paulhcsun paulhcsun

Labels
effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2 star-contributor [Pilot] contributed between 25-49 PRs to the CDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

aws-apprunner: support private access from VPC
5 participants
@mazyu36 @paulhcsun @aws-cdk-automation @lpizzinidev @shikha372