chore: remove sdkv2 from cloudformation-diff #29730
Conversation
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
aws-cdk-automation
added
the
pr/needs-cli-test-run
TheRealAmazonKendra
temporarily deployed
to
test-pipeline
GitHub Actions
Inactive
TheRealAmazonKendra
changed the title
|
➡️ PR build request submitted to A maintainer must now check the pipeline and add the |
| Evaluation: 'Direct', | ||
| Evaluation: 'Static', |
There was a problem hiding this comment.
Curious, do you mind explaining why we needed to change the Evaluation type from Direct to Static?
There was a problem hiding this comment.
This was not a valid value before but in v2 it wasn't strongly typed enough for it to matter in our test case.
| import * as impl from './diff'; | ||
| import * as types from './diff/types'; | ||
| import { deepEqual, diffKeyedEntities, unionOf } from './diff/util'; | ||
|
|
||
| export * from './diff/types'; | ||
|
|
||
| export type DescribeChangeSetOutput = DescribeChangeSet; |
There was a problem hiding this comment.
why both this and the import? The change on line 3 lets us reference this type as DescribeChangeSet, but without the as, you could achieve the same result we get from both lines 3 and 10.
There was a problem hiding this comment.
This type is used extensively throughout aws-cdk (the cli, not the entire package). This re-export is a workaround In order to not cause a conflict of types in that package. You could argue that we should just migrate that whole package, but that's a much more complex task that we have not yet prioritized.
| "@aws-sdk/[email protected]": | ||
| version "3.540.0" |
There was a problem hiding this comment.
I guess these are fine? ideally the changes to yarn.lock would reflect only the diff in package.json, but node dependency tooling is funny
There was a problem hiding this comment.
These get pulled in because they are used by @aws-sdk/client-cloudformation.
TheRealAmazonKendra
added
the
pr-linter/cli-integ-tested
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
aws-cdk-automation
removed
the
pr/needs-cli-test-run
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
@Mergifyio update |
☑️ Nothing to do
|
TheRealAmazonKendra
had a problem deploying
to
test-pipeline
GitHub Actions
Failure
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one. |
Issue # (if applicable)
Closes #.
Reason for this change
Description of changes
Description of how you validated changes
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license