Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli): support CloudFormation simplified resource import #28066

Closed
wants to merge 17 commits into from
Closed

feat(cli): support CloudFormation simplified resource import #28066

wants to merge 17 commits into from

Conversation

tmokmss
Copy link
Contributor

@tmokmss tmokmss commented Nov 19, 2023 •
edited
Loading

Closes #28060

This PR adds a CLI option --import-exsting-resources: boolean to cdk deploy command and pass it to createChangeSet API call.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added star-contributor [Pilot] contributed between 25-49 PRs to the CDK feature-request A feature should be added or improved. p2 labels Nov 19, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team November 19, 2023 15:01
aws-cdk-automation
aws-cdk-automation requested changes Nov 19, 2023
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@aws-cdk-automation aws-cdk-automation added the pr/needs-cli-test-run This PR needs CLI tests run against it. label Nov 19, 2023
@tmokmss
Copy link
Contributor Author

tmokmss commented Nov 19, 2023 •
edited
Loading

Exemption Request: I added a CLI integ test instead of framework-integ, because this is a change of CLI.

@aws-cdk-automation aws-cdk-automation added the pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. label Nov 19, 2023
@github-actions github-actions bot mentioned this pull request Dec 1, 2023
Closed
@tmokmss tmokmss mentioned this pull request Dec 4, 2023
Closed
@github-actions github-actions bot added the effort/medium Medium work item – several days of effort label Dec 7, 2023
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Dec 7, 2023
@aws-cdk-automation
Copy link
Collaborator

This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

@tmokmss
Copy link
Contributor Author

tmokmss commented Dec 11, 2023

@vinayak-kukreja Hi, by any chance, can you run a CLI integ test pipeline and add an integ exempt label to keep this PR open?

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 3cc542d
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

msambol
msambol reviewed Dec 14, 2023
View reviewed changes
packages/@aws-cdk-testing/cli-integ/tests/cli-integ-tests/cli.integtest.ts
await expect(fixture.aws.cloudFormation('describeStacks', {
StackName: fixture.fullStackName(stackName),
})).rejects.toThrow('does not exist');
}));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for adding this 👍🏼

@msambol
Copy link
Contributor

msambol commented Dec 14, 2023

LGTM 👍🏼 Thanks for adding this!

msambol
msambol approved these changes Dec 15, 2023
View reviewed changes
Copy link
Contributor

@msambol msambol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks 👍🏼

@aws-cdk-automation aws-cdk-automation added pr/needs-maintainer-review This PR needs a review from a Core Team Member and removed pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Dec 15, 2023
@aws-cdk-automation
Copy link
Collaborator

The pull request linter fails with the following errors:

❌ Features must contain a change to an integration test file and the resulting snapshot.
❌ CLI code has changed. A maintainer must run the code through the testing pipeline (git fetch origin pull/28066/head && git push -f origin FETCH_HEAD:test-main-pipeline), then add the 'pr-linter/cli-integ-tested' label when the pipeline succeeds.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.

@aws-cdk-automation
Copy link
Collaborator

This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.

@aws-cdk-automation aws-cdk-automation added the closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. label Dec 18, 2023
@aws-cdk-automation
Copy link
Collaborator

The pull request linter fails with the following errors:

❌ Features must contain a change to an integration test file and the resulting snapshot.
❌ CLI code has changed. A maintainer must run the code through the testing pipeline (git fetch origin pull/28066/head && git push -f origin FETCH_HEAD:test-main-pipeline), then add the 'pr-linter/cli-integ-tested' label when the pipeline succeeds.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.

@tmokmss tmokmss mentioned this pull request Dec 18, 2023
Closed
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 18, 2023

⚠️ The sha of the head commit of this PR conflicts with #28401. Mergify cannot evaluate rules on this PR. ⚠️

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 6, 2024

⚠️ The sha of the head commit of this PR conflicts with #28401. Mergify cannot evaluate rules on this PR. ⚠️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aws-cdk-automation aws-cdk-automation aws-cdk-automation requested changes

@msambol msambol msambol approved these changes

Assignees
No one assigned
Labels
closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2 pr/needs-cli-test-run This PR needs CLI tests run against it. pr/needs-maintainer-review This PR needs a review from a Core Team Member pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. star-contributor [Pilot] contributed between 25-49 PRs to the CDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cli: support CloudFormation simplified resource import
3 participants
@tmokmss @aws-cdk-automation @msambol