-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(synthetics): syn-python-selenium-2.0 runtime #27565
feat(synthetics): syn-python-selenium-2.0 runtime #27565
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @frichtarik! See my 1 comment, but also this PR needs an update to an existing integ test and then that integ test needs to be run and updated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we're not gonna add anything to the alpha package, its deprecated. in fact i'm removing the entire package today.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clarification Request
I see it now, thank you.
I've limited the PR to non-alpha package, however i'm required by linter GHA to adjust integration tests ... can you please point a finger as I don't see any in the package, and i'm a bit afraid that creating full suite is a bit out of scope of my first ever contribution :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The integ tests live in @aws-cdk-testing/framework-integ/test/aws-synthetics
The information for how to run is here.
You probably need to add a line very similar to this and then run the integ tests:
aws-cdk/packages/@aws-cdk-testing/framework-integ/test/aws-synthetics/test/integ.canary.ts
Line 101 in c445b8c
const selenium13 = createCanaryByRuntimes(Runtime.SYNTHETICS_PYTHON_SELENIUM_1_3); |
@frichtarik if you can't/haven't run the integ tests, I can run them for you. |
i'll be actually glad, because i tried to run them on my own but they failed every time on creating autodeleteobject lambda related to s3 with |
hmm interesting. this seems like a problem with our integ runner somewhere. i get the same error, but not when i deploy the stack with |
…/github.com/frichtarik/aws-cdk into feature/24704-add-missing-synthetic-runtime
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
adding missing selenium runtime for synthetics package
Closes #27566.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license