-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(eks): managed node groups can specify updateConfig #27320
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!
I left you a couple of comments in the code.
Also, unit tests should be added here to verify the validation rules and that the update configuration are generated correcly.
Co-authored-by: Luca Pizzini <[email protected]>
Co-authored-by: Luca Pizzini <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes 💪
Some changes are needed in documentation and validation.
Also, I think maxUnavailable
should default to undefined
since updateConfig
is not required.
Changing this should also fix build errors due to failing functional tests.
Co-authored-by: Luca Pizzini <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Last minor adjustments and it will be good to go for me.
Thank you for providing documentation for the maxSize
constraint and suggesting the correct default values.
Co-authored-by: Luca Pizzini <[email protected]>
Co-authored-by: Luca Pizzini <[email protected]>
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 👍
I've created a new branch with these changes, but I don't see a way to edit this PR. When you say reopen do you mean open a new one? |
@kishiel |
New PR: #27593 |
|
…27593) This is a duplicate of [PR 27320](#27320) but on a new branch in my repo. This change enables nodegroups to configure updateConfig properties which will allow nodegroups to upgrade more than 1 instance at a time. The default value of 1 results in slow deployment times which prevented my service pipelines from quickly delivering fixes to my customers. This change allows each nodegroup to specify a maximum count of instances, or percent, which can be upgraded in parallel.
Adds the updateConfig to managed node groups so that node version upgrades can move faster than the default of 1 instance at a time. The default value resulted in slow deployments (sometimes hours) to occur, which were blocking fixes from getting through my service pipelines. This change will allow us to increase the velocity of changes for our customers.
Design
Not much going on here, the plumbing already existed, I just exposed the updateConfig on the interfaces.
Testing
Created a sample stack which included the change and deployed successfully. I added the updateConfig to the integ.eks-cluster test for both attributes of the updateConfig and both worked.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license