Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add --from-stack to cdk migrate command #27155

Merged
merged 2 commits into from
Sep 15, 2023

Conversation

TheRealAmazonKendra
Copy link
Contributor

This change includes a refactor to migrate to align more closely with how the other cli commands are implemented.

--from-stack also allows users to set the account and region to get the stack template from.

Not included in this PR:

  1. Integ tests - this PR has been manually tested and automated tests will be added in a subsequent PR.
  2. Go support - there are still some bugs to work out with go (in cdk-from-cfn) so implementation for it will be added after that's been worked out.
  3. The option to compress the app to a zip file

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team September 15, 2023 03:15
@github-actions github-actions bot added the p2 label Sep 15, 2023
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Sep 15, 2023
@TheRealAmazonKendra TheRealAmazonKendra temporarily deployed to test-pipeline September 15, 2023 03:16 — with GitHub Actions Inactive
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@aws-cdk-automation aws-cdk-automation added the pr/needs-cli-test-run This PR needs CLI tests run against it. label Sep 15, 2023
This change includes a refactor to migrate to align more closely with how the other cli commands are implemented.
@TheRealAmazonKendra TheRealAmazonKendra force-pushed the TheRealAmazonKendra/migrate-stack-name branch from 3d30b3e to 5f65e99 Compare September 15, 2023 03:39
@TheRealAmazonKendra TheRealAmazonKendra temporarily deployed to test-pipeline September 15, 2023 03:40 — with GitHub Actions Inactive
@TheRealAmazonKendra TheRealAmazonKendra added the pr-linter/cli-integ-tested Assert that any CLI changes have been integ tested label Sep 15, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review September 15, 2023 04:55

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added pr/needs-maintainer-review This PR needs a review from a Core Team Member and removed pr/needs-cli-test-run This PR needs CLI tests run against it. labels Sep 15, 2023
@mergify
Copy link
Contributor

mergify bot commented Sep 15, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Sep 15, 2023
@mergify
Copy link
Contributor

mergify bot commented Sep 15, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot temporarily deployed to test-pipeline September 15, 2023 15:54 Inactive
@aws-cdk-automation
Copy link
Collaborator

➡️ PR build request submitted to test-main-pipeline ⬅️

A maintainer must now check the pipeline and add the pr-linter/cli-integ-tested label once the pipeline succeeds.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 11adad2
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 452b868 into main Sep 15, 2023
8 checks passed
@mergify mergify bot deleted the TheRealAmazonKendra/migrate-stack-name branch September 15, 2023 16:17
@mergify
Copy link
Contributor

mergify bot commented Sep 15, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p2 pr-linter/cli-integ-tested Assert that any CLI changes have been integ tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants