Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(msk): integ test for batch associate scram secrets custom resource #27106

Merged
merged 5 commits into from
Sep 12, 2023

Conversation

colifran
Copy link
Contributor

Adding an integ test for this custom resource with our new rule that each custom resource needs at least one integ test. This integ test is asserting that one scram secret per user is being registered with the cluster when SASL/SCRAM authentication is used.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Sep 11, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team September 11, 2023 22:21
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Sep 11, 2023
@colifran colifran marked this pull request as ready for review September 12, 2023 04:19
@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Sep 12, 2023
@mergify
Copy link
Contributor

mergify bot commented Sep 12, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Sep 12, 2023
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 277a793
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 444cc7d into main Sep 12, 2023
11 checks passed
@mergify mergify bot deleted the colifran/msk-scram-secrets branch September 12, 2023 11:24
@mergify
Copy link
Contributor

mergify bot commented Sep 12, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mikewrighton pushed a commit that referenced this pull request Sep 14, 2023
…rce (#27106)

Adding an integ test for this custom resource with our new rule that each custom resource needs at least one integ test. This integ test is asserting that one scram secret per user is being registered with the cluster when SASL/SCRAM authentication is used.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants