Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eks): undefined constructor in custom resource #26782

Merged
merged 2 commits into from
Aug 16, 2023
Merged

fix(eks): undefined constructor in custom resource #26782

merged 2 commits into from
Aug 16, 2023

Conversation

MrArnoldPalmer
Copy link
Contributor

When we upgraded the proxy-agent v6 we did not update how we were importing from the package. Where in 5.0 commonjs exports were used , in 6.0 a named esm export is used.

Updated to use a named import statement instead of a default require. Typescript also confirms the old import was an error now since we use import instead of require.

Fixes: #26771


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

When we [upgraded the proxy-agent v6](#26722)
we did not update how we were importing from the package. Where
[in 5.0 commonjs exports were used](https://github.com/TooTallNate/node-proxy-agent/blob/5.0.0/index.js#L25)
, in [6.0 a named esm export is used](https://github.com/TooTallNate/proxy-agents/blob/proxy-agent%406.1.0/packages/proxy-agent/src/index.ts#L71).

Updated to use a named import statement instead of a default require.
Typescript also confirms the old import was an error now since we use
`import` instead of `require`.

Fixes: #26771
@aws-cdk-automation aws-cdk-automation requested a review from a team August 16, 2023 22:45
@github-actions github-actions bot added the p2 label Aug 16, 2023
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Aug 16, 2023
@MrArnoldPalmer
Copy link
Contributor Author

I ran the eks-cluster integ test using --force because it doesn't have diffAssets enabled. I confirmed that this test was failing with the expected error before. I did not --force the run of all of the other eks integ tests because they take literally forever.

We should diffAssets on all of these tests but it results in needing to re-run them on a cadence that is currently intolerable without automation doing it for us.

@mergify
Copy link
Contributor

mergify bot commented Aug 16, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 9d28930
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 0b8f31d into main Aug 16, 2023
8 checks passed
@mergify mergify bot deleted the fix/26771 branch August 16, 2023 23:36
@mergify
Copy link
Contributor

mergify bot commented Aug 16, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

eks: ProxyAgent is not a constructor
3 participants