feat(apprunner): Add VPC Ingress Connection #22931
Conversation
|
|
github-actions
bot
added
beginning-contributor
|
@JethroBakker-dotcom thanks for taking the time to work on this PR! Since this is a |
|
This PR has been in the MERGE CONFLICTS state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week. |
| const service = new apprunner.Service(this, 'Service', { | ||
| source: apprunner.Source.fromEcrPublic({ | ||
| imageConfiguration: { port: 8000 }, | ||
| imageIdentifier: 'public.ecr.aws/aws-containers/hello-app-runner:latest', |
There was a problem hiding this comment.
We should build this for the user instead of having them add the entire string, if possible. For instance, because of the function beingfromEcrPublic we already know that the prefix of it will be public.ecr.aws/ so this should only ask for the pieces that we don't know and build it for the user.
There was a problem hiding this comment.
I understand your comment but I don't think it is related to this PR, other parts of the README also mention this type of imageIdentifier.
| * Import from VPC Ingress Connection attributes. | ||
| */ | ||
| public static fromVpcIngressConnectionAttributes(scope: Construct, id: string, attrs: VpcIngressConnectionAttributes): IVpcIngressConnection { | ||
| const vpcIngressConnectionArn = attrs.vpcIngressConnectionArn; |
There was a problem hiding this comment.
Can you add a function to look up the VPC by ARN? fromVpcIngressConnectionArn
There was a problem hiding this comment.
And one to look it up by name? fromVpcIngressConnectionName
|
This PR has been in the BUILD FAILING state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week. |
mergify
bot
dismissed
TheRealAmazonKendra’s stale review
Pull request has been modified.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Implements #22850
All Submissions:
Adding new Unconventional Dependencies:
New Features
yarn integto deploy the infrastructure and generate the snapshot (i.e.yarn integwithout--dry-run)?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license