fix(core): Add hook for applying aspects to new constructs created during and after aspects invocation #22903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
bug
github-actions
bot
added
the
beginning-contributor
aws-cdk-automation
requested changes
Nov 13, 2022
rv2673
force-pushed
the
feature/#22820-apply-aspects-on-postconstruct-constructs
branch
from
3eb9c1b
to
ac8717c
Compare
|
This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week. |
…ring and after aspects invocation TODO upgrade constructs when required hooks feature is added
rv2673
force-pushed
the
feature/#22820-apply-aspects-on-postconstruct-constructs
branch
from
ac8717c
to
262f796
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error. |
aws-cdk-automation
added
the
closed-for-staleness
|
The pull request linter fails with the following errors: PRs must pass status checks before we can provide a meaningful review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add hook for applying aspects to new constructs created during and after aspects invocation.
Fixes #22820.
TODO:
All Submissions:
Adding new Unconventional Dependencies:
New Features
(Not yet, would like some feedback on the change and guidance what should be tested in the integration test).
yarn integto deploy the infrastructure and generate the snapshot (i.e.yarn integwithout--dry-run)?(No currently unable to do so)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license