Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Move Schedule classes to core and remove duplicates #8979

Closed
civilizeddev opened this issue Jul 9, 2020 · 2 comments
Closed

[core] Move Schedule classes to core and remove duplicates #8979

civilizeddev opened this issue Jul 9, 2020 · 2 comments
Labels
@aws-cdk/core Related to core CDK functionality closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. in-progress This issue is being actively worked on. p2

Comments

@civilizeddev
Copy link
Contributor

civilizeddev commented Jul 9, 2020

❓ General Issue

The Question

/**
* Schedule for scheduled scaling actions
*/
export abstract class Schedule {

/**
* Schedule for scheduled scaling actions
*/
export abstract class Schedule {

/**
* Schedule for scheduled event rules
*/
export abstract class Schedule {

The classes above are almost the same.

What about moving them all to @aws-cdk/core and remove duplicates?

It will be more useful in the core module.

Environment

  • CDK CLI Version: 1.50.0
  • Module Version: 1.50.0
  • Node.js Version: 14.5.0
  • OS: macOS Catalina
  • Language (Version): TypeScript (3.9.6)

Other information

@civilizeddev civilizeddev added the needs-triage This issue or PR still needs to be triaged. label Jul 9, 2020
@github-actions github-actions bot added the @aws-cdk/core Related to core CDK functionality label Jul 9, 2020
@SomayaB SomayaB added the feature-request A feature should be added or improved. label Jul 9, 2020
@eladb eladb added the effort/small Small work item – less than a day of effort label Jul 16, 2020
@eladb
Copy link
Contributor

eladb commented Jul 16, 2020

Sounds good. Happy to take a contribution.

@SomayaB SomayaB removed the needs-triage This issue or PR still needs to be triaged. label Jul 17, 2020
@SomayaB SomayaB added the in-progress This issue is being actively worked on. label Jul 24, 2020
@eladb eladb added the p2 label Aug 17, 2020
@eladb eladb assigned rix0rrr and unassigned eladb Aug 17, 2020
@rix0rrr rix0rrr removed their assignment Jun 3, 2021
@github-actions
Copy link

github-actions bot commented Jun 3, 2022

This issue has not received any attention in 1 year. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.

@github-actions github-actions bot added closing-soon This issue will automatically close in 4 days unless further comments are made. closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. and removed closing-soon This issue will automatically close in 4 days unless further comments are made. labels Jun 3, 2022
@github-actions github-actions bot closed this as completed Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/core Related to core CDK functionality closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. in-progress This issue is being actively worked on. p2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants