Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make cdk diff CI/CD friendly #5392

Closed
1 of 2 tasks
abelmokadem opened this issue Dec 12, 2019 · 2 comments
Closed
1 of 2 tasks

Make cdk diff CI/CD friendly #5392

abelmokadem opened this issue Dec 12, 2019 · 2 comments
Labels
feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged.

Comments

@abelmokadem
Copy link
Contributor

Related to: #1440

Use Case

I want to run cdk diff in my CI/CD pipeline and if there is a change in the stack, I want the pipeline to succeed. If there is an error in trying to generate the diff, I want the pipeline to fail. (exit code > 0)

Proposed Solution

Leave the cdk diff behaviour as is, but add a flag that can change the exit code behaviour as mentioned in the use case.

Other

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request
@abelmokadem abelmokadem added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Dec 12, 2019
@shivlaks
Copy link
Contributor

hey @abelmokadem - Is this a duplicate of #4721 ?

@abelmokadem
Copy link
Contributor Author

@shivlaks oops, didn't see this PR yet. Looking forward to seeing this get released :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@abelmokadem @shivlaks