Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to identify missing local dependencies during build #5114

Closed
eladb opened this issue Nov 19, 2019 · 2 comments · Fixed by #5452
Closed

Unable to identify missing local dependencies during build #5114

eladb opened this issue Nov 19, 2019 · 2 comments · Fixed by #5452
Assignees
Labels
bug This issue is a bug. in-progress This issue is being actively worked on. management/devenv Related to CDK development/build environment p1

Comments

@eladb
Copy link
Contributor

eladb commented Nov 19, 2019

Since yarn currently hoists all local dependencies into the root node_modules, modules can accidentally use a dependency that they don't declare in their package.json. This causes latent production issues such as #1030

We should figure out a way to disable local-dependency hoisting or not use yarn because this is a huge gap in our test coverage.

@eladb eladb added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. p0 labels Nov 19, 2019
@SomayaB SomayaB added management/devenv Related to CDK development/build environment and removed needs-triage This issue or PR still needs to be triaged. labels Nov 19, 2019
@jogold
Copy link
Contributor

jogold commented Nov 19, 2019

Solution with ESLint https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/no-extraneous-dependencies.md

Essential when working with yarn workspaces

Should be integrated in #3430

@eladb
Copy link
Contributor Author

eladb commented Nov 19, 2019

Sounds great

@eladb eladb added p1 and removed p0 labels Nov 22, 2019
@RomainMuller RomainMuller changed the title Unable to identify missing local dependencies during build #1031 Unable to identify missing local dependencies during build Dec 17, 2019
@SomayaB SomayaB added the in-progress This issue is being actively worked on. label Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. in-progress This issue is being actively worked on. management/devenv Related to CDK development/build environment p1
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants