Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking changes for core services & enterprise acceptance #5045

Closed
peterpicard opened this issue Nov 15, 2019 · 3 comments
Closed

Breaking changes for core services & enterprise acceptance #5045

peterpicard opened this issue Nov 15, 2019 · 3 comments
Assignees
Labels
feature-request A feature should be added or improved. needs-design This feature request needs additional design work. needs-discussion This issue/PR requires more discussion with community.

Comments

@peterpicard
Copy link

❓ General Issue

The Question

First, I would like to say that I am a big fan of the development work everyone is doing on this project. A big thumbs up!

I work in a large enterprise environment and consult multiple external customers. I would love to use the CDK for all AWS infra management, but am concerned with the frequency of breaking changes for core service constructs (RDS in v0.15.0 for example). It's been quite a few months since it went GA.

Is there a roadmap for when the CDK will be in a state where enterprise operation teams can adopt it and count on the fact that the CDK code written last year will still work in a DR scenario this year, without needing to be locked to old/outdated CDK versions?

Thanks for your time and answer.

Environment

  • CDK CLI Version: 1.16.1 (build 9a5a761)
  • Module Version: RDS
  • OS: all
  • Language: Python

Other information

Suggestions:

  • breaking changes for core service constructs (RDS, EC2, etc) should be bundled into major version upgrades and not minor ones, as was the case for v0.15.0
  • introduce stable/enterprise branches similar to what Redhat is doing with RHEL/Fedora
  • introduce a migration tool to help automate the refactoring of CDK code to be compatible with the latest CDK version (i.e. automatically fix issues for RDS code when moving from v0.14.0 -> v0.15.0)
@peterpicard peterpicard added the needs-triage This issue or PR still needs to be triaged. label Nov 15, 2019
@SomayaB SomayaB added the guidance Question that needs advice or information. label Nov 15, 2019
@thesurlydev
Copy link
Contributor

I've often wondered about the versioning choice myself. It seems there are breaking changes with almost every new release yet only the minor version changes. An assumption could be made that semantic versioning is used but as soon as someone sees breaking changes while not changing major version, I'm sure it causes confusion.

While I was very excited about this project and began recommending to teams in my org, this combination of weird versioning and continually breaking changes has made me reconsider. Breaking changes are fine but please come up with a better solution than you have now for communicating and segregating them in a way that doesn't cause confusion.

@ccfife
Copy link
Contributor

ccfife commented May 6, 2020

Here is an issue in the aws-cdk-rfcs repo where we are discussing how to address this problem. Feel free to chime in with your feedback there. aws/aws-cdk-rfcs#116

@ccfife ccfife added investigating This issue is being investigated and/or work is in progress to resolve the issue. and removed needs-triage This issue or PR still needs to be triaged. labels May 6, 2020
@SomayaB SomayaB added feature-request A feature should be added or improved. needs-design This feature request needs additional design work. needs-discussion This issue/PR requires more discussion with community. and removed guidance Question that needs advice or information. investigating This issue is being investigated and/or work is in progress to resolve the issue. labels Jun 22, 2020
@SomayaB SomayaB assigned eladb and unassigned fulghum Jun 22, 2020
@eladb
Copy link
Contributor

eladb commented Jun 23, 2020

Closing in favor of aws/aws-cdk-rfcs#116

@eladb eladb closed this as completed Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved. needs-design This feature request needs additional design work. needs-discussion This issue/PR requires more discussion with community.
Projects
None yet
Development

No branches or pull requests

6 participants