fix(msk): clusterName validation in Cluster class is incorrect

[mazyu36]

Issue # (if applicable)

N/A

Reason for this change

The validation for clusterName is incorrect. There are two issues:

1. The AND (&&) operators should be OR (||) operators. Currently, the validation throws an error only when both the pattern check AND length check fail.
   However, it should throw an error when EITHER check fails.

    if (
      !core.Token.isUnresolved(props.clusterName) &&
      !/^[a-zA-Z0-9]+$/.test(props.clusterName) &&
      props.clusterName.length > 64
    ) 

2. The pattern check is too restrictive. The current validation only allows alphanumeric characters, but hyphens (-) should also be allowed.

Additionally, the error message in the AWS Management Console appears to be inconsistent with the actual validation requirements.

Description of changes

Removed cluster name validation due to the following reasons:

• The current validation is incorrect and not functioning as intended.
• While the correct pattern is not documented in CFn docs. So updating the validation might introduce regressions.
• As suggested by maintainers' comments, there is an opinion that pattern validation should not be implemented in CDK. Ref

Since the correct pattern is not documented clearly, I think removing the validation would be the preferable approach.

Describe any new or updated permissions being added

Nothing.

Description of how you validated changes

Nothing because only remove validation.

Checklist

• My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[aws-cdk-automation]

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.41%. Comparing base (e33ebb4) to head (015a985).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #32792   +/-   ##
=======================================
  Coverage   81.41%   81.41%           
=======================================
  Files         223      223           
  Lines       13721    13721           
  Branches     2416     2416           
=======================================
  Hits        11171    11171           
  Misses       2271     2271           
  Partials      279      279           

Flag	Coverage Δ
suite.unit	81.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
packages/aws-cdk	80.75% <ø> (ø)
packages/aws-cdk-lib/core	82.10% <ø> (ø)

[mazyu36]

Exemption Request: I think adding tests is unnecessary because this change only involves removing existing validation logic.

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: 015a985
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[github-actions]

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.