Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(aws-dynamodb): add ApproximateCreationDateTimePrecision to kinesisStream #31760

Open
2 tasks done
LeeroyHannigan opened this issue Oct 15, 2024 · 2 comments · May be fixed by #31761
Open
2 tasks done

(aws-dynamodb): add ApproximateCreationDateTimePrecision to kinesisStream #31760

LeeroyHannigan opened this issue Oct 15, 2024 · 2 comments · May be fixed by #31761
Labels
@aws-cdk/aws-dynamodb Related to Amazon DynamoDB effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2

Comments

@LeeroyHannigan
Copy link
Contributor

Describe the feature

kinesisStream is lacking the capability to choose the ApproximateCreationDateTimePrecision.

https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-dynamodb-table-kinesisstreamspecification.html

Use Case

Feature compatibility with CFN

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.162.1

Environment details (OS name and version, etc.)

MacOS
@LeeroyHannigan LeeroyHannigan added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Oct 15, 2024
@github-actions github-actions bot added the @aws-cdk/aws-dynamodb Related to Amazon DynamoDB label Oct 15, 2024
@LeeroyHannigan
Copy link
Contributor Author

I'll implement this feature.

@LeeroyHannigan LeeroyHannigan linked a pull request Oct 15, 2024 that will close this issue
Open
1 task
@khushail khushail added investigating This issue is being investigated and/or work is in progress to resolve the issue. p2 and removed needs-triage This issue or PR still needs to be triaged. labels Oct 15, 2024
@khushail khushail self-assigned this Oct 15, 2024
@khushail
Copy link
Contributor

Hi @LeeroyHannigan , thanks for creating this FR and submitting the PR for this. This is supported by Cloudformation - https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.aws_dynamodb.CfnGlobalTable.KinesisStreamSpecificationProperty.html ,so it makes sense to have it available via CDK.

Thanks for your efforts!

@khushail khushail added effort/small Small work item – less than a day of effort and removed investigating This issue is being investigated and/or work is in progress to resolve the issue. labels Oct 16, 2024
@khushail khushail removed their assignment Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-dynamodb Related to Amazon DynamoDB effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(dynamodb): adding kinesis timestamp precision LeeroyHannigan/aws-cdk
2 participants
@LeeroyHannigan @khushail