Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(autoscaling): applyCloudFormationInit on each launchTemplateOverrides of mixedInstancesPolicy #31315

Closed
1 task
BDeus opened this issue Sep 4, 2024 · 2 comments
Assignees
Labels
@aws-cdk/aws-autoscaling Related to Amazon EC2 Auto Scaling bug This issue is a bug. closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. needs-reproduction This issue needs reproduction. p2 response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days.

Comments

@BDeus
Copy link
Contributor

BDeus commented Sep 4, 2024

Describe the bug

Reopening of #27030

In the Construct AutoscalingGroup when setting a CloudFormationInit, the UserData is apply on the LaunchTemplate attach to the ASG. (attach here)
In case of using a MixedInstancesPolicy with LaunchTemplateOverrides, the templates overrides do not inherit from the UserData of the CloudFormationInit.

Regression Issue

  • Select this option if this issue appears to be a regression.

Last Known Working CDK Version

No response

Expected Behavior

Set the CfnSignals in all LaunchTemplates of the AutoscalingGroup when a CloudFormationInit is attach.

attachOptions.userData.addCommands(

Current Behavior

The UserData build by the AutoscalingGroup and the Cloudformation does not set the signals on the overrides template, only on the default one.

Reproduction Steps

Create an AutoscalingGroup with a MixedInstancesPolicy with two LaunchTemplates
Attach a CloudFormationInit to the AutoscalingGroup.
On synthetize, all LaunchTemplates need to have the signals generate by the CloudFormationInit

Possible Solution

No response

Additional Information/Context

No response

CDK CLI Version

2.123.0

Framework Version

No response

Node.js Version

20.11.1

OS

macos

Language

TypeScript, Java

Language Version

No response

Other information

No response

@BDeus BDeus added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Sep 4, 2024
@github-actions github-actions bot added the @aws-cdk/aws-autoscaling Related to Amazon EC2 Auto Scaling label Sep 4, 2024
@khushail khushail added needs-reproduction This issue needs reproduction. p2 investigating This issue is being investigated and/or work is in progress to resolve the issue. and removed needs-triage This issue or PR still needs to be triaged. labels Sep 5, 2024
@khushail khushail self-assigned this Sep 5, 2024
@khushail
Copy link
Contributor

Hi @BDeus , Thanks for reaching out.
Could you please share the minimal reproducible sample code for the issue mentioned. It would also be very helpful if you could share the synthesized template as well.

@khushail khushail added response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. labels Sep 11, 2024
Copy link

This issue has not received a response in a while. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.

@github-actions github-actions bot added the closing-soon This issue will automatically close in 4 days unless further comments are made. label Sep 13, 2024
@khushail khushail removed the investigating This issue is being investigated and/or work is in progress to resolve the issue. label Sep 17, 2024
@github-actions github-actions bot added closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. and removed closing-soon This issue will automatically close in 4 days unless further comments are made. labels Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-autoscaling Related to Amazon EC2 Auto Scaling bug This issue is a bug. closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. needs-reproduction This issue needs reproduction. p2 response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days.
Projects
None yet
Development

No branches or pull requests

2 participants