Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(aws-cloudfront): Support TrustedSigners #30154

Open
2 tasks
steven10172 opened this issue May 10, 2024 · 1 comment
Open
2 tasks

(aws-cloudfront): Support TrustedSigners #30154

steven10172 opened this issue May 10, 2024 · 1 comment
Labels
@aws-cdk/aws-cloudfront Related to Amazon CloudFront effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2

Comments

@steven10172
Copy link

steven10172 commented May 10, 2024 •
edited by ashishdhingra
Loading

Describe the feature

In the CDK there are 2 constructs for CloudFront (WebDistribution and Distribution). The WebDistribution was updated (ref) to support trustedSigners along with trustedKeyGroups, but the Distribution construct only supports trustedKeyGroups.

Can we update Distribution to add support for trustedSigners?

Use Case

As a developer who maintains a CloudFront distribution in CDK library I need support for trustedSigners as the signer will not exist in the account that the CDK constructs are deployed to. The signer will remain a core organization account that has permission to sign the requests.

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.141.0

Environment details (OS name and version, etc.)

MacOS M1 Pro 13.5.2
@steven10172 steven10172 added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels May 10, 2024
@github-actions github-actions bot added the @aws-cdk/aws-cloudfront Related to Amazon CloudFront label May 10, 2024
This was referenced May 13, 2024
Closed
Closed
@ashishdhingra ashishdhingra added investigating This issue is being investigated and/or work is in progress to resolve the issue. and removed needs-triage This issue or PR still needs to be triaged. labels May 13, 2024
@ashishdhingra ashishdhingra self-assigned this May 13, 2024
@ashishdhingra
Copy link
Contributor

CacheBehaviorProperty supports both trustedSigners and trustedKeyGroups.

Just for reference:

@ashishdhingra ashishdhingra added p2 effort/small Small work item – less than a day of effort and removed investigating This issue is being investigated and/or work is in progress to resolve the issue. labels May 14, 2024
@ashishdhingra ashishdhingra removed their assignment May 14, 2024
@github-actions github-actions bot mentioned this issue Jun 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-cloudfront Related to Amazon CloudFront effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@steven10172 @ashishdhingra