Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws-cdk-lib.aws_dynamodb: Resource Policy property #29600

Closed
2 tasks done
clouddev-code opened this issue Mar 25, 2024 · 4 comments · Fixed by #30251
Closed
2 tasks done

aws-cdk-lib.aws_dynamodb: Resource Policy property #29600

clouddev-code opened this issue Mar 25, 2024 · 4 comments · Fixed by #30251
Labels
aws-cdk-lib Related to the aws-cdk-lib package effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2

Comments

@clouddev-code
Copy link

Describe the feature

DynamoDB Resource Policy was supported recently.
https://aws.amazon.com/about-aws/whats-new/2024/03/amazon-dynamodb-resource-based-policies/

L2 Constructs donot have blocker for ResourcePolicy is supported in CloudFormation.
https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-dynamodb-table-resourcepolicy.html

Use Case

DynamoDB ResourcePolicy set by L2 Constructs.

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.133.0

Environment details (OS name and version, etc.)

M1 Mac, node18
@clouddev-code clouddev-code added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Mar 25, 2024
@github-actions github-actions bot added the aws-cdk-lib Related to the aws-cdk-lib package label Mar 25, 2024
@tim-finnigan tim-finnigan self-assigned this Mar 25, 2024
@tim-finnigan tim-finnigan added investigating This issue is being investigated and/or work is in progress to resolve the issue. and removed needs-triage This issue or PR still needs to be triaged. labels Mar 25, 2024
@tim-finnigan
Copy link

Thanks for the feature request!

@tim-finnigan tim-finnigan added p2 effort/medium Medium work item – several days of effort and removed investigating This issue is being investigated and/or work is in progress to resolve the issue. labels Mar 25, 2024
@tim-finnigan tim-finnigan removed their assignment Mar 25, 2024
@LeeroyHannigan
Copy link
Contributor

You can assign this one to me.

This was referenced Apr 1, 2024
Closed
Closed
Closed
LeeroyHannigan pushed a commit to LeeroyHannigan/aws-cdk that referenced this issue Apr 12, 2024
Add reource polices to DynamoDB Table aws#29600
e113524
@LeeroyHannigan LeeroyHannigan mentioned this issue Apr 12, 2024
Closed
LeeroyHannigan pushed a commit to LeeroyHannigan/aws-cdk that referenced this issue Apr 12, 2024
Add resource polices to DynamoDB Table aws#29600
7915c7e
@LeeroyHannigan LeeroyHannigan mentioned this issue May 17, 2024
Merged
@mergify mergify bot closed this as completed in #30251 May 29, 2024
@mergify mergify bot closed this as completed in 7dc6d27 May 29, 2024
@github-actions GitHub Actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

1 similar comment
@github-actions GitHub Actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

atanaspam pushed a commit to atanaspam/aws-cdk that referenced this issue Jun 3, 2024
@LeeroyHannigan @atanaspam
feat(dynamodb): add resource polices for table (aws#30251)
0f6c8b8 
Issue # (if applicable)

Closes aws#29600.

aws#29600
Reason for this change

Adding a new feature
Description of changes

Add resourcePolicy for DynamoDB Table component in aws-dynamodb
Description of how you validated changes

integration test integ.dynamodb.policy.ts
Checklist

    [X ] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
vdahlberg pushed a commit to vdahlberg/aws-cdk that referenced this issue Jun 10, 2024
@LeeroyHannigan
feat(dynamodb): add resource polices for table (aws#30251)
d4b3756 
Issue # (if applicable)

Closes aws#29600.

aws#29600
Reason for this change

Adding a new feature
Description of changes

Add resourcePolicy for DynamoDB Table component in aws-dynamodb
Description of how you validated changes

integration test integ.dynamodb.policy.ts
Checklist

    [X ] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@aws aws locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
aws-cdk-lib Related to the aws-cdk-lib package effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
3 participants
@LeeroyHannigan @clouddev-code @tim-finnigan