Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(core): crossRegionReference resources can not be modified by Aspects #27780

Open
btan-godaddy opened this issue Oct 31, 2023 · 1 comment
Open
Labels
@aws-cdk/core Related to core CDK functionality bug This issue is a bug. effort/medium Medium work item – several days of effort p1

Comments

@btan-godaddy
Copy link
Contributor

Describe the bug

This is same issue that has been opened here #22820.

When developers turn on crossRegionReference flag https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib-readme.html, cdk will create custom resources including lambdas and roles. But these custom resources could not be modified by Aspect application we built that tries to make resources conform to predefined rules. For example, we have enabled AWS Hook in aws account that requires IAM roles can be only be created with names has certain prefix. If those resources can not be modified, AWS hook will prevent from resource creation.

Expected Behavior

Custom resources created by enabling crossRegionReference should be modified by Aspects.

Current Behavior

Custom resources created by enabling crossRegionReference could not be modified by Aspects.

Reproduction Steps

const stack1 = new Stack(app, "Stack1", {
  env: {
    region: "us-east-1",
  },
  crossRegionReferences: true,
});

Possible Solution

No response

Additional Information/Context

No response

CDK CLI Version

2.93.0

Framework Version

No response

Node.js Version

20.5.7

OS

MAC

Language

TypeScript

Language Version

No response

Other information

No response

@btan-godaddy btan-godaddy added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Oct 31, 2023
@github-actions github-actions bot added the @aws-cdk/core Related to core CDK functionality label Oct 31, 2023
@pahud
Copy link
Contributor

pahud commented Nov 1, 2023

related to #22820

@pahud pahud added p1 effort/medium Medium work item – several days of effort and removed needs-triage This issue or PR still needs to be triaged. labels Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/core Related to core CDK functionality bug This issue is a bug. effort/medium Medium work item – several days of effort p1
Projects
None yet
Development

No branches or pull requests

2 participants