Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@aws-cdk/aws-glue-alpha: Add description to Glue table object #27740

Closed
2 tasks
ksco92 opened this issue Oct 28, 2023 · 4 comments · Fixed by #27744
Closed
2 tasks

@aws-cdk/aws-glue-alpha: Add description to Glue table object #27740

ksco92 opened this issue Oct 28, 2023 · 4 comments · Fixed by #27744
Labels
@aws-cdk/aws-glue Related to AWS Glue effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2

Comments

@ksco92
Copy link

ksco92 commented Oct 28, 2023

Describe the feature

Glue tables can already be created with CDK:

https://docs.aws.amazon.com/cdk/api/v2/docs/@aws-cdk_aws-glue-alpha.Database.html

For the purpose of documentation and data governance, the database description field from CFN should be added to this:

https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-glue-database-databaseinput.html#cfn-glue-database-databaseinput-description

Use Case

This will help people that created their data lakes fully on AWS with CDK to embed documentation on IaC. Having to use a different API or manually changing database descriptions is not a feasible option for large scale users with hundreds of databases.

Proposed Solution

Add the description field to the props of the database object.

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

latest

Environment details (OS name and version, etc.)

MacOS

@ksco92 ksco92 added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Oct 28, 2023
@github-actions github-actions bot added the @aws-cdk/aws-glue Related to AWS Glue label Oct 28, 2023
@msambol
Copy link
Contributor

msambol commented Oct 29, 2023

I'll take this.

@khushail khushail added p2 effort/small Small work item – less than a day of effort and removed needs-triage This issue or PR still needs to be triaged. labels Oct 30, 2023
@khushail
Copy link
Contributor

@ksco92 ,thanks for submitting this feature request.

@msambol , appreciate your contribution of PR.

@ksco92
Copy link
Author

ksco92 commented Oct 31, 2023

Thanks for the quick turnaround, what is the timeline for this to be released now?

@mergify mergify bot closed this as completed in #27744 Dec 30, 2023
mergify bot pushed a commit that referenced this issue Dec 30, 2023
Closes #27740.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

paulhcsun pushed a commit to paulhcsun/aws-cdk that referenced this issue Jan 5, 2024
Closes aws#27740.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-glue Related to AWS Glue effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants