(aws-s3-deployment): (Errors on resource deletion when retainOnDelete is set to false)

[massi-ang]

Describe the bug

I deployed a stack using BucketDeployment construct with reatinOnDelete=false
I then changed the construct name in the stack and redeployed.
The stack would correctly try to remove the old files, but an error is thrown:

3:21:06 PM | DELETE_FAILED        | AWS::CloudFormation::CustomResource             | ...omResourceE9F2C2EB
Received response status [FAILED] from custom resource. Message returned: Command '['/opt/awscli/aws', 's3', 'rm', 's3://bucket-xyz-zf6fdg25ehh1/build-script', '--recursive']' returned non-zero exit status 1. (RequestId: e52c1279-8e5f-466a-9b49-f01d1098e6e5)

Expected Behavior

Files are correctly removed if present

Current Behavior

An error is thrown (see above)

Reproduction Steps

Deploy something first using:

 new s3deploy.BucketDeployment(this, "Script", {
      sources: [s3deploy.Source.asset(path.join(__dirname, "./build-script"))],
      retainOnDelete: false,
      destinationBucket: buildBucket,
      destinationKeyPrefix: "build-script",
    });

then change the construct resource name and redeploy

 new s3deploy.BucketDeployment(this, "Script-new", {
      sources: [s3deploy.Source.asset(path.join(__dirname, "./build-script"))],
      retainOnDelete: false,
      destinationBucket: buildBucket,
      destinationKeyPrefix: "build-script",
    });

Possible Solution

Automatically add the necessary permission to the custom resource Lambda function

Additional Information/Context

No response

CDK CLI Version

2.99.1 (build b2a895e)

Framework Version

2.99.1

Node.js Version

v20.2.0

OS

MacOS

Language

TypeScript

Language Version

5.1.3

Other information

No response

[khushail]

Hi @massi-ang , thanks for reaching out.

As stated here for the retainOnDelete flag, I tried to repro the issue with the code provided, but it succeeded as stated. cdk diff produces this result -

could you please share the result of cdk diff which might help in understanding the issue on your side.

[massi-ang]

Hi Shailja

thank for the prompt answer. I confirm that the BucketDeployment works as expected and the issue is with the Bucket resource.
See #27660

[github-actions]

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.