-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aws-redshift-alpha: remove backtick ` from the user passwords #26847
aws-redshift-alpha: remove backtick ` from the user passwords #26847
Comments
I think some have been excluded but I agree to expose the secret as an optional property.
|
@pahud quote and double quote sure are! double checking on that password, it was the backtick that got me. updated the ticket to reflect. thanks! |
Yeah I guess we could simply create a tiny PR to add the backtick in or just expose the secret prop to the surface. |
Comments on closed issues and PRs are hard for our team to see. |
1 similar comment
Comments on closed issues and PRs are hard for our team to see. |
Describe the feature
As per https://docs.aws.amazon.com/cdk/api/v2/docs/aws-redshift-alpha-readme.html#creating-users
Could you also please exclude backtick ` or expose the secret configuration?
Use Case
When integrating with DBT airflow dags that use redshift, we have a generated password with backtick. The password has to be written as an environment variable to keep it out of dbt profiles yaml. The backtick are problematic. This had to be fixed manually.
Proposed Solution
Simplest, add more characters to the list excluded from the password
Other Information
No response
Acknowledgements
CDK version used
2.85.0 (build 4e0d726)
Environment details (OS name and version, etc.)
Mac Os
The text was updated successfully, but these errors were encountered: