Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws-cdk-lib: NotificationARN must be passed by constructor to actually send notifications #26741

Open
michelececcacci opened this issue Aug 13, 2023 · 2 comments
Labels
@aws-cdk/core Related to core CDK functionality documentation This is a problem with documentation. effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p3

Comments

@michelececcacci
Copy link

Describe the issue

Spent quite a bit of time on this, thinking that i was doing something wrong. I thought that we could just push to the notificationARNs array, but turns out the cloudformation output isn't produced in the template. I had to pass the array from the constructor (as props) to make it work. I feel like this should be mentioned in the documentation, and i'm willing to submit a PR myself.

Links

https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.NestedStack.html

@michelececcacci michelececcacci added documentation This is a problem with documentation. needs-triage This issue or PR still needs to be triaged. labels Aug 13, 2023
@github-actions github-actions bot added the aws-cdk-lib Related to the aws-cdk-lib package label Aug 13, 2023
@pahud
Copy link
Contributor

pahud commented Aug 14, 2023

can you explain more about your intention and provide your code snippet if possible?

@pahud pahud added p2 response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. and removed needs-triage This issue or PR still needs to be triaged. labels Aug 14, 2023
@michelececcacci
Copy link
Author

I can't share the code here, but basically i was trying to send notifications to a specific arn (my queue0. My first approach , was to push on the notificationARNs array. I assumed this would work, since the array contained the desired ARN (verified through unit test). The thing is, the actual cloudformation output didn't contain the actual ARN (no ARNs at all actually, since that was the only one i was passing). When i passed the array as a prop from the constructor, i reached the desired output.

@github-actions github-actions bot removed the response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. label Aug 14, 2023
@tim-finnigan tim-finnigan added feature-request A feature should be added or improved. effort/small Small work item – less than a day of effort labels Mar 14, 2024
@pahud pahud added p3 and removed p2 labels Jun 11, 2024
@moelasmar moelasmar added @aws-cdk/core Related to core CDK functionality and removed aws-cdk-lib Related to the aws-cdk-lib package labels Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/core Related to core CDK functionality documentation This is a problem with documentation. effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p3
Projects
None yet
Development

No branches or pull requests

4 participants