(ecr): make validateRepositoryName errors human readable

[scanlonp]

Describe the feature

The current errors say repository names must match a long regex. Make the errors explain why the name was not valid in an understandable way.

Use Case

Understanding why a repository name is not valid without deciphering regex.

Proposed Solution

Translate the regex into words in the error messages.

Other Information

No response

Acknowledgements

• I may be able to implement this feature request
• This feature might incur a breaking change

CDK version used

2.91.0

Environment details (OS name and version, etc.)

Mac

[scanlonp]

For reference

aws-cdk/packages/aws-cdk-lib/aws-ecr/lib/repository.ts

Lines 659 to 681 in e593229

	private static validateRepositoryName(physicalName: string) {
	const repositoryName = physicalName;
	if (!repositoryName || Token.isUnresolved(repositoryName)) {
	// the name is a late-bound value, not a defined string,
	// so skip validation
	return;
	}
	const errors: string[] = [];
	// Rules codified from https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-ecr-repository.html
	if (repositoryName.length < 2 || repositoryName.length > 256) {
	errors.push('Repository name must be at least 2 and no more than 256 characters');
	}
	const isPatternMatch = /^(?:[a-z0-9]+(?:[._-][a-z0-9]+)*\/)*[a-z0-9]+(?:[._-][a-z0-9]+)*$/.test(repositoryName);
	if (!isPatternMatch) {
	errors.push('Repository name must follow the specified pattern: (?:[a-z0-9]+(?:[._-][a-z0-9]+)*/)*[a-z0-9]+(?:[._-][a-z0-9]+)*');
	}
	if (errors.length > 0) {
	throw new Error(`Invalid ECR repository name (value: ${repositoryName})${EOL}${errors.join(EOL)}`);
	}
	}

[pahud]

Yeah it makes sense to improve the error messages here.

[github-actions]

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.