Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(aws-batch-alpha): Construct Props RuntimePlatform #26484

Closed
2 tasks
gmarchand opened this issue Jul 24, 2023 · 8 comments · Fixed by #28841
Closed
2 tasks

(aws-batch-alpha): Construct Props RuntimePlatform #26484

gmarchand opened this issue Jul 24, 2023 · 8 comments · Fixed by #28841
Assignees
@xazhao
Labels
@aws-cdk/aws-batch Related to AWS Batch effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md p2

Comments

@gmarchand
Copy link

Describe the feature

The property RuntimePlatform is not present in the interface IEcsContainerDefinition

Use Case

I would want to use AWS Batch with Fargate on ARM64 as describe in this news : https://aws.amazon.com/about-aws/whats-new/2023/07/aws-batch-fargate-linux-arm64-windows-x86-containers-cli-sdk/

To do that customers will need to create ARM64 or Windows job definition using RegisterJobDefinition API of AWS Batch. ARM64-based and Windows-based containers are supported in all Fargate on-demand compute environments.

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.88.0

Environment details (OS name and version, etc.)

All OS
@gmarchand gmarchand added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jul 24, 2023
@github-actions github-actions bot added the @aws-cdk/aws-batch Related to AWS Batch label Jul 24, 2023
@gmarchand gmarchand mentioned this issue Jul 24, 2023
Open
@pahud
Copy link
Contributor

pahud commented Jul 24, 2023

Makes sense to me. We could add RuntimePlatform in

aws-cdk/packages/@aws-cdk/aws-batch-alpha/lib/ecs-container-definition.ts

Line 361 in f22bd4e

export interface IEcsContainerDefinition extends IConstruct {

@pahud pahud added good first issue Related to contributions. See CONTRIBUTING.md p2 effort/small Small work item – less than a day of effort and removed needs-triage This issue or PR still needs to be triaged. labels Jul 24, 2023
@khushail
Copy link
Contributor

working on it.

@khushail khushail mentioned this issue Jul 26, 2023
Closed
@github-actions github-actions bot mentioned this issue Aug 1, 2023
Closed
@gmarchand
Copy link
Author

Hello @khushail @pahud the bot @aws-cdk-automation closed your PR last week #26506 (comment)
And the release https://github.com/aws/aws-cdk/releases/tag/v2.96.0 has stabilized the aws-batch module

Do you think your code is still up to date ?

@khushail
Copy link
Contributor

Hi @gmarchand , I need to fix some comments, will do it this week hopefully and update the PR. Thanks for checking.

@gmarchand
Copy link
Author

Hello, Any update on this one ?

@khushail
Copy link
Contributor

@gmarchand , Apologies, I could not spend much time on finishing this as got into some other priority work. Please feel free to work on the PR. Contributions are welcome from the community as well.

@khushail khushail mentioned this issue Nov 29, 2023
Closed
2 tasks
@mtheindiecoder
Copy link

I can take over this one.
@gmarchand

@xazhao xazhao self-assigned this Jan 17, 2024
This was referenced Jan 19, 2024
Closed
Merged
@mergify mergify bot closed this as completed in #28841 Jan 30, 2024
mergify bot pushed a commit that referenced this issue Jan 30, 2024
@xazhao
feat(batch): add fargate Runtime Platform properties to ECS Fargate C… (
ac8251f 
#28841)

The property [RuntimePlatform](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-batch-jobdefinition-containerproperties.html#cfn-batch-jobdefinition-containerproperties-runtimeplatform) is not present in the AWS Batch ECS Fargate Job Definition. This PR adds flatten properties fargateCpuArchitecture and fargateOperatingSystemFamily to the ECS Fargate Job Definition in AWS Batch.

Closes #26484.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions GitHub Actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

SankyRed pushed a commit that referenced this issue Feb 8, 2024
@xazhao @SankyRed
feat(batch): add fargate Runtime Platform properties to ECS Fargate C… (
c3f339d 
#28841)

The property [RuntimePlatform](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-batch-jobdefinition-containerproperties.html#cfn-batch-jobdefinition-containerproperties-runtimeplatform) is not present in the AWS Batch ECS Fargate Job Definition. This PR adds flatten properties fargateCpuArchitecture and fargateOperatingSystemFamily to the ECS Fargate Job Definition in AWS Batch.

Closes #26484.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xazhao xazhao

Labels
@aws-cdk/aws-batch Related to AWS Batch effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md p2
Projects
None yet
Milestone
No milestone
5 participants
@pahud @gmarchand @xazhao @khushail @mtheindiecoder