Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(apprunner): incorrect serviceName #26015

Merged
merged 5 commits into from
Jun 20, 2023
Merged

fix(apprunner): incorrect serviceName #26015

merged 5 commits into from
Jun 20, 2023

Conversation

pahud
Copy link
Contributor

@pahud pahud commented Jun 16, 2023

The AppRunner Service L2 construct returns serviceArn attribute as the serviceName. As Cloudformation does not return serivceName attribute(see return values). This PR splits the serviceArn to extract the serviceName instead.

Closes #26002

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Jun 16, 2023

@github-actions github-actions bot added bug This issue is a bug. effort/small Small work item – less than a day of effort p1 labels Jun 16, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team June 16, 2023 15:29
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jun 16, 2023
@pahud pahud marked this pull request as ready for review June 16, 2023 15:30
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jun 16, 2023
@mergify
Copy link
Contributor

mergify bot commented Jun 19, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Jun 19, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jun 19, 2023
@mergify
Copy link
Contributor

mergify bot commented Jun 19, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 27b7185
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit ad89f01 into aws:main Jun 20, 2023
@mergify
Copy link
Contributor

mergify bot commented Jun 20, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@filletofish filletofish mentioned this pull request Jul 2, 2023
Merged
@peterwoodworth peterwoodworth mentioned this pull request Jul 5, 2023
Closed
@github-actions github-actions bot mentioned this pull request Jul 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@otaviomacedo otaviomacedo otaviomacedo approved these changes

Assignees
No one assigned
Labels
bug This issue is a bug. contribution/core This is a PR that came from AWS. effort/small Small work item – less than a day of effort p1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

aws-apprunner-alpha: serviceName return service ARN instead name
3 participants
@pahud @aws-cdk-automation @otaviomacedo