Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SageMaker Notebook Interface VPC Endpoint does not deploy (service name is incorrect) #2597

Closed
chriswessells opened this issue May 20, 2019 · 3 comments
Labels
bug This issue is a bug.

Comments

@chriswessells
Copy link
Contributor

chriswessells commented May 20, 2019

Describe the bug
The SageMaker Notebook Interface VPC Endpoint does not deploy. The service name is incorrect.

When deploying I receive the following error
The Vpc Endpoint Service 'aws.sagemaker.us-west-2.sagemaker' does not exist (Service: AmazonEC2; Status Code: 400; Error Code: InvalidServiceName; Request ID: bb11fb4a-b775-49b3-958c-f75cc8dcd63c)

To Reproduce
Create directory SagemakerWorkflow
cd SagemakerWorkflow
cdk init --language typescript
below is the sagemaker_workflow-stack.ts file
import cdk = require('@aws-cdk/cdk');
import ec2 = require('@aws-cdk/aws-ec2');
export class SagemakerWorkflowStack extends cdk.Stack {
constructor(scope: cdk.Construct, id: string, props?: cdk.StackProps) {
super(scope, id, props);
const vpc = new ec2.VpcNetwork(this, 'sagemakerVpc', {
maxAZs: 2,
natGateways: 1,
gatewayEndpoints: {
S3: {
service: ec2.GatewayVpcEndpointAwsService.S3
}
}
});
const sageMakerNotebookEndpoint = vpc.addInterfaceEndpoint('sageMakerNotebookEndpoint', {
service: ec2.InterfaceVpcEndpointAwsService.SageMakerNotebook
});
sageMakerNotebookEndpoint.connections.allowDefaultPortFromAnyIpv4();
}
}

Expected behavior
When creating a SageMaker Notebook Interface VPC Endpoint, it should deploy

Version:

  • OS Mac
  • Programming Language Typescript
  • CDK Version 0.31
@chriswessells chriswessells added the bug This issue is a bug. label May 20, 2019
@chriswessells
Copy link
Contributor Author

chriswessells commented May 20, 2019

in file aws-cdk/packages/@aws-cdk/aws-ec2/lib/vpc-endpoint.ts

line 208 should be
public static readonly SageMakerNotebook = new InterfaceVpcEndpointAwsService('notebook', 'aws.sagemaker');

I'm building the cdk now to test

@chriswessells
Copy link
Contributor Author

Tested the changes and the recommended change to line 208 of file aws-cdk/packages/@aws-cdk/aws-ec2/lib/vpc-endpoint.ts deployed the endpoint successfully.

@nija-at
Copy link
Contributor

nija-at commented Aug 21, 2019

Closing this issue. Already fixed in PR #2598

@nija-at nija-at closed this as completed Aug 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug.
Projects
None yet
Development

No branches or pull requests

2 participants