Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(glue): glue tables can include storage parameters #24498

Merged
merged 44 commits into from
Jul 31, 2023
Merged

feat(glue): glue tables can include storage parameters #24498

merged 44 commits into from
Jul 31, 2023

Conversation

Rizxcviii
Copy link
Contributor

Includes a storageParameters property, allowing developers to access the tableInput.storageDescriptor.parameters property within the CfnTable resource.

Closes #23132.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 labels Mar 7, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team March 7, 2023 14:55
@github-actions github-actions bot added the repeat-contributor [Pilot] contributed between 3-5 PRs to the CDK label Mar 7, 2023
comcalvi
comcalvi previously requested changes Mar 7, 2023
View reviewed changes
packages/@aws-cdk/aws-glue/lib/table.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-glue/README.md Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-glue/test/integ.table.ts Outdated Show resolved Hide resolved
@mergify mergify bot dismissed comcalvi’s stale review March 8, 2023 12:25

Pull request has been modified.

@Rizxcviii Rizxcviii requested a review from comcalvi March 8, 2023 15:17
comcalvi
comcalvi previously requested changes Mar 9, 2023
View reviewed changes
Copy link
Contributor

@comcalvi comcalvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for clarifying. I think we can use typing to our advantage here to fix some silent failures that can occur.

packages/@aws-cdk/aws-glue/lib/table.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-glue/lib/table.ts Outdated Show resolved Hide resolved
@mergify mergify bot dismissed comcalvi’s stale review March 10, 2023 16:20

Pull request has been modified.

@Rizxcviii Rizxcviii requested a review from comcalvi March 21, 2023 11:11
@aws-cdk-automation
Copy link
Collaborator

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

2 similar comments
@aws-cdk-automation
Copy link
Collaborator

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

@aws-cdk-automation
Copy link
Collaborator

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

@mrgrain mrgrain added effort/medium Medium work item – several days of effort and removed effort/small Small work item – less than a day of effort labels Jul 25, 2023
@mergify mergify bot dismissed mrgrain’s stale review July 28, 2023 14:39

Pull request has been modified.

@Rizxcviii Rizxcviii requested a review from mrgrain July 28, 2023 14:41
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jul 28, 2023
@mrgrain mrgrain self-assigned this Jul 28, 2023
mrgrain
mrgrain previously approved these changes Jul 31, 2023
View reviewed changes
@mergify
Copy link
Contributor

mergify bot commented Jul 31, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@Rizxcviii
Copy link
Contributor Author

@Mergifyio refresh

@mergify
Copy link
Contributor

mergify bot commented Jul 31, 2023

refresh

✅ Pull request refreshed

@Rizxcviii
Copy link
Contributor Author

@mrgrain
Mergify doesn't have permission to update

For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/close-stale-issues.yml without workflows permission
err-code: 68F63

This is causing the merge to fail for some reason?

@mrgrain
Copy link
Contributor

mrgrain commented Jul 31, 2023

Thanks! I have to click a button and reapprove.

@mergify mergify bot dismissed mrgrain’s stale review July 31, 2023 20:09

Pull request has been modified.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: cb96655
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Jul 31, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit f1df9ab into aws:main Jul 31, 2023
10 checks passed
@Rizxcviii Rizxcviii deleted the feature/glue-table-properties-parameters branch July 31, 2023 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrgrain mrgrain mrgrain approved these changes

@comcalvi comcalvi Awaiting requested review from comcalvi

@TheRealAmazonKendra TheRealAmazonKendra Awaiting requested review from TheRealAmazonKendra

Assignees

@mrgrain mrgrain

@TheRealAmazonKendra TheRealAmazonKendra

Labels
@aws-cdk/aws-glue Related to AWS Glue effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2 pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. repeat-contributor [Pilot] contributed between 3-5 PRs to the CDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(@aws-cdk.aws-glue-alpha): Glue table separator + skip header
7 participants
@Rizxcviii @aws-cdk-automation @aram-eskandari @comcalvi @mrgrain @corymhall @TheRealAmazonKendra