Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codepipeline-actions: Outdated link in Readme on ECS deployment role #24248

Closed
faridnsh opened this issue Feb 21, 2023 · 3 comments · Fixed by #24452
Closed

codepipeline-actions: Outdated link in Readme on ECS deployment role #24248

faridnsh opened this issue Feb 21, 2023 · 3 comments · Fixed by #24452
Labels
@aws-cdk/aws-codepipeline-actions documentation This is a problem with documentation. effort/small Small work item – less than a day of effort p2

Comments

@faridnsh
Copy link

Describe the issue

This link about permissions of cross account ECS deployment role is outdated and redirects to the main page of Codepipeline docs: https://github.com/aws/aws-cdk/blob/52edf29/packages/@aws-cdk/aws-codepipeline-actions/README.md?plain=1#L848

Basically I want to know how exactly should that role be created for cross account access.

Links

https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.aws_codepipeline_actions-readme.html#ecs
https://github.com/aws/aws-cdk/blob/52edf29/packages/@aws-cdk/aws-codepipeline-actions/README.md?plain=1#L848

@faridnsh faridnsh added documentation This is a problem with documentation. needs-triage This issue or PR still needs to be triaged. labels Feb 21, 2023
@khushail
Copy link
Contributor

Hi @alFReD-NSH ,thanks for reporting this. I can confirm the same as seen by you.

Reg. the role creation for cross-account access, this link might be helpful to go through.
I also found somewhat similar issue in the past, with the suggested solution(#17917 (comment)).

Let me know if this does not resolve what you are looking for. Would be happy to assist further. Thanks

@khushail khushail added p2 effort/small Small work item – less than a day of effort and removed needs-triage This issue or PR still needs to be triaged. labels Feb 21, 2023
@khushail khushail self-assigned this Feb 21, 2023
@faridnsh
Copy link
Author

this link might be helpful to go through.

That's about ECS task assuming role into another account. I want to know how to create the IAM role for cross account deployment via EcsDeployAction.

I also found somewhat similar issue in the past, with the suggested solution(#17917 (comment)).

Yes, I read it as it was the first result on Google. It doesn't show how the IAM role should be created.

@khushail khushail added the needs-reproduction This issue needs reproduction. label Mar 1, 2023
@khushail khushail removed their assignment Mar 1, 2023
@mergify mergify bot closed this as completed in #24452 Mar 9, 2023
mergify bot pushed a commit that referenced this issue Mar 9, 2023
…ne (#24452)

Closes #24248

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

github-actions bot commented Mar 9, 2023

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

homakk pushed a commit to homakk/aws-cdk that referenced this issue Mar 28, 2023
…ne (aws#24452)

Closes aws#24248

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@pahud pahud removed the needs-reproduction This issue needs reproduction. label Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-codepipeline-actions documentation This is a problem with documentation. effort/small Small work item – less than a day of effort p2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants