Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gamelift): restrict policy to access Script / Build content in S3 #22767

Merged

Conversation

stevehouel
Copy link
Contributor

@stevehouel stevehouel commented Nov 3, 2022

Restrict S3 policy to restrict access to script or build content stored in S3.

Integration tests has been upgraded to new integ-tests version

All Submissions:

Adding new Unconventional Dependencies:

  • This PR adds new unconventional dependencies following the process described here

New Features

  • Have you added the new feature to an integration test?
    • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Nov 3, 2022
@gitpod-io
Copy link

gitpod-io bot commented Nov 3, 2022

@github-actions github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label Nov 3, 2022
@aws-cdk-automation aws-cdk-automation requested a review from a team November 3, 2022 16:23
@otaviomacedo otaviomacedo added the @aws-cdk/aws-gamelift Related to Amazon GameLift label Nov 8, 2022
@mergify
Copy link
Contributor

mergify bot commented Nov 8, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 1fd5f4c
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit c936002 into aws:main Nov 8, 2022
@mergify
Copy link
Contributor

mergify bot commented Nov 8, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@stevehouel stevehouel deleted the houes/rfc-436-migrate-script-integ-test branch November 8, 2022 14:47
iliapolo pushed a commit that referenced this pull request Nov 9, 2022
…#22767)

Restrict S3 policy to restrict access to script or build content stored in S3.

Integration tests has been upgraded to new integ-tests version
----

### All Submissions:

* [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [x] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)?
	* [x] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-gamelift Related to Amazon GameLift beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants