Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(appsync): domain name api association fails when domain name creation is in the same stack #20173

Merged
merged 5 commits into from
Jul 14, 2022

Conversation

kochie
Copy link
Contributor

@kochie kochie commented May 2, 2022

Fixes #18395 and other issues where defining domain name in aws-appsync-alpha will fail because domain name is not created before the domain name association.


All Submissions:

Adding new Unconventional Dependencies:

  • This PR adds new unconventional dependencies following the process described here

New Features

  • Have you added the new feature to an integration test?
    • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented May 2, 2022

@github-actions github-actions bot added bug This issue is a bug. p2 labels May 2, 2022
@aws-cdk-automation aws-cdk-automation requested a review from a team May 2, 2022 15:46
@kochie
Copy link
Contributor Author

kochie commented May 3, 2022

Build seems to be failing due to an error in @aws-cdk/aws-lambda-python which isn't touched in this PR. Can anyone confirm?

@kochie kochie changed the title fix(appsync): adds dependency for domain name association fix(aws-appsync): adds dependency for domain name association May 31, 2022
@TheRealAmazonKendra TheRealAmazonKendra changed the title fix(aws-appsync): adds dependency for domain name association fix(appsync): add dependency for domain name association Jul 14, 2022
@TheRealAmazonKendra TheRealAmazonKendra changed the title fix(appsync): add dependency for domain name association fix(appsync): domain name api association fails when domain name creation is in the same stack Jul 14, 2022
Copy link
Contributor

@TheRealAmazonKendra TheRealAmazonKendra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

@mergify
Copy link
Contributor

mergify bot commented Jul 14, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 30af2c1
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit c1495f0 into aws:main Jul 14, 2022
@mergify
Copy link
Contributor

mergify bot commented Jul 14, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. p2
Projects
None yet
3 participants