feat(lambda): add support for ephemeral storage #19552

robertd · 2022-03-25T04:23:35Z

Depends on cfnspec bump PR #19553

CFN Docs: https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-lambda-function-ephemeralstorage.html

Blog: https://aws.amazon.com/blogs/aws/aws-lambda-now-supports-up-to-10-gb-ephemeral-storage/

Closes #19605.

All Submissions:

Have you followed the guidelines in our Contributing guide?

Adding new Unconventional Dependencies:

This PR adds new unconventional dependencies following the process described here

New Features

Have you added the new feature to an integration test?
- Did you use cdk-integ to deploy the infrastructure and generate the snapshot (i.e. cdk-integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

gitpod-io · 2022-03-25T04:23:40Z

robertd · 2022-03-25T16:03:12Z

@kaizen3031593 This PR is ready for your review. It'd be awesome if it could make it the next cdk release. Thanks!

kaizencc

Hi @robertd! Thanks for being on top of this feature! Please add a test that shows that ephemeralStorageSize works and also one to show that an unresolved token does not throw an error.

packages/@aws-cdk/aws-lambda/lib/function.ts

packages/@aws-cdk/aws-lambda/test/function.test.ts

packages/@aws-cdk/aws-lambda/README.md

Co-authored-by: Kaizen Conroy <[email protected]>

Pull request has been modified.

Co-authored-by: Kaizen Conroy <[email protected]>

robertd · 2022-03-25T21:37:10Z

@kaizen3031593 Do we need integ tests? I don’t see any for memorySize so I didn’t bother. Lmk

robertd · 2022-03-28T20:34:35Z

@kaizen3031593 Back to your original comment... should we move this to Size at all? Will that break developer experience given that memorySize is already a number?

@kaizen3031593 Do we need integ tests? I don’t see any for memorySize so I didn’t bother. Lmk

@kaizen3031593 Any thoughts?

madeline-k

Hey @robertd , @kaizen3031593 is on vacation this week. I'll be taking over the review here. I am good to approve after you switch to using cdk.Size and add a couple unit tests.

packages/@aws-cdk/aws-lambda/lib/function.ts

packages/@aws-cdk/aws-lambda/README.md

packages/@aws-cdk/aws-lambda/test/function.test.ts

packages/@aws-cdk/aws-lambda/lib/function.ts

Co-authored-by: Rico Huijbers <[email protected]>

Pull request has been modified.

Co-authored-by: Rico Huijbers <[email protected]>

robertd · 2022-04-01T02:18:33Z

@kaizen3031593 @madeline-k @rix0rrr PR ready for review. Thanks in advance.

madeline-k

Looks good to me. Thanks, @robertd!

mergify · 2022-04-01T03:23:36Z

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

aws-cdk-automation · 2022-04-01T04:16:22Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
Commit ID: 0a4bde8
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mergify · 2022-04-01T04:16:42Z

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

khoatrandata · 2022-04-06T00:04:46Z

thanks for the work @robertd , @madeline-k ! Wonder any chance this can be released in a couple days?

robertd · 2022-04-06T01:35:33Z

@khoatrandata Most likely 2.20.0 will be released by the end of this week. CDK team is good at releasing at least once a week.

See [CHANGELOG](https://github.com/aws/aws-cdk/blob/bump/1.152.0/CHANGELOG.md) For convenience, extracted the relevant CHANGELOG entry: ## [1.152.0](v1.151.0...v1.152.0) (2022-04-06) ### Features * **cfnspec:** cloudformation spec v63.0.0 ([#19679](#19679)) ([dba96a9](dba96a9)) * **cfnspec:** cloudformation spec v65.0.0 ([#19745](#19745)) ([796fc64](796fc64)) * **cli:** add --build option ([#19663](#19663)) ([eb9b8e2](eb9b8e2)), closes [#19667](#19667) * **cli:** preview of `cdk import` ([#17666](#17666)) ([4f12209](4f12209)) * **core:** throw error when stack name exceeds max length ([#19725](#19725)) ([1ffd45e](1ffd45e)) * **eks:** add k8s v1.22 ([#19756](#19756)) ([9a518c5](9a518c5)) * **opensearch:** Add latest Opensearch Version 1.2 ([#19749](#19749)) ([a2ac36e](a2ac36e)) * add new integration test runner ([#19754](#19754)) ([1b4d010](1b4d010)) * **eks:** alb-controller v2.4.1 ([#19653](#19653)) ([1ec08df](1ec08df)) * **lambda:** add support for ephemeral storage ([#19552](#19552)) ([f1d9b6a](f1d9b6a)), closes [#19605](#19605) * **s3:** EventBridge bucket notifications ([#18614](#18614)) ([d8e602b](d8e602b)), closes [#18076](#18076) * **synthetics:** new puppeteer 3.5 runtime ([#19673](#19673)) ([ce2b91b](ce2b91b)), closes [#19634](#19634) ### Bug Fixes * **aws_applicationautoscaling:** Add missing members to PredefinedMetric enum ([#18978](#18978)) ([75a6fa7](75a6fa7)), closes [#18969](#18969) * **cli:** apps with many resources scroll resource output offscreen ([#19742](#19742)) ([053d22c](053d22c)), closes [#19160](#19160) * **cli:** support attributes of DynamoDB Tables for hotswapping ([#19620](#19620)) ([2321ece](2321ece)), closes [#19421](#19421) * **cloudwatch:** automatic metric math label cannot be suppressed ([#17639](#17639)) ([7fa3bf2](7fa3bf2)) * **codedeploy:** add name validation for Application, Deployment Group and Deployment Configuration ([#19473](#19473)) ([9185042](9185042)) * **codedeploy:** the Service Principal is wrong in isolated regions ([#19729](#19729)) ([7e9a43d](7e9a43d)), closes [#19399](#19399) * **core:** `Fn.select` incorrectly short-circuits complex expressions ([#19680](#19680)) ([7f26fad](7f26fad)) * **core:** detect and resolve stringified number tokens ([#19578](#19578)) ([7d9ab2a](7d9ab2a)), closes [#19546](#19546) [#19550](#19550) * **core:** reduce CFN template indent size to save bytes ([#19656](#19656)) ([fd63ca3](fd63ca3)) * **ecs:** 'desiredCount' and 'ephemeralStorageGiB' cannot be tokens ([#19453](#19453)) ([c852239](c852239)), closes [#16648](#16648) * **ecs:** remove unnecessary error when adding volume to external task definition ([#19774](#19774)) ([5446ded](5446ded)), closes [#19259](#19259) * **iam:** policies aren't minimized as far as possible ([#19764](#19764)) ([876ed8a](876ed8a)), closes [#19751](#19751) * **logs:** Faulty Resource Policy Generated ([#19640](#19640)) ([1fdf122](1fdf122)), closes [#17544](#17544)

See [CHANGELOG](https://github.com/aws/aws-cdk/blob/bump/2.20.0/CHANGELOG.md) For convenience, extracted the relevant CHANGELOG entry: ## [2.20.0](v2.19.0...v2.20.0) (2022-04-07) ### Features * **cfnspec:** cloudformation spec v63.0.0 ([#19679](#19679)) ([dba96a9](dba96a9)) * **cfnspec:** cloudformation spec v65.0.0 ([#19745](#19745)) ([796fc64](796fc64)) * **cli:** add --build option ([#19663](#19663)) ([eb9b8e2](eb9b8e2)), closes [#19667](#19667) * **cli:** preview of `cdk import` ([#17666](#17666)) ([4f12209](4f12209)) * **core:** throw error when stack name exceeds max length ([#19725](#19725)) ([1ffd45e](1ffd45e)) * **eks:** add k8s v1.22 ([#19756](#19756)) ([9a518c5](9a518c5)) * **opensearch:** Add latest Opensearch Version 1.2 ([#19749](#19749)) ([a2ac36e](a2ac36e)) * add new integration test runner ([#19754](#19754)) ([1b4d010](1b4d010)) * **eks:** alb-controller v2.4.1 ([#19653](#19653)) ([1ec08df](1ec08df)) * **lambda:** add support for ephemeral storage ([#19552](#19552)) ([f1d9b6a](f1d9b6a)), closes [#19605](#19605) * **s3:** EventBridge bucket notifications ([#18614](#18614)) ([d8e602b](d8e602b)), closes [#18076](#18076) ### Bug Fixes * **aws_applicationautoscaling:** Add missing members to PredefinedMetric enum ([#18978](#18978)) ([75a6fa7](75a6fa7)), closes [#18969](#18969) * **cli:** apps with many resources scroll resource output offscreen ([#19742](#19742)) ([053d22c](053d22c)), closes [#19160](#19160) * **cli:** support attributes of DynamoDB Tables for hotswapping ([#19620](#19620)) ([2321ece](2321ece)), closes [#19421](#19421) * **cloudwatch:** automatic metric math label cannot be suppressed ([#17639](#17639)) ([7fa3bf2](7fa3bf2)) * **codedeploy:** add name validation for Application, Deployment Group and Deployment Configuration ([#19473](#19473)) ([9185042](9185042)) * **codedeploy:** the Service Principal is wrong in isolated regions ([#19729](#19729)) ([7e9a43d](7e9a43d)), closes [#19399](#19399) * **core:** `Fn.select` incorrectly short-circuits complex expressions ([#19680](#19680)) ([7f26fad](7f26fad)) * **core:** detect and resolve stringified number tokens ([#19578](#19578)) ([7d9ab2a](7d9ab2a)), closes [#19546](#19546) [#19550](#19550) * **core:** reduce CFN template indent size to save bytes ([#19656](#19656)) ([fd63ca3](fd63ca3)) * **ecs:** 'desiredCount' and 'ephemeralStorageGiB' cannot be tokens ([#19453](#19453)) ([c852239](c852239)), closes [#16648](#16648) * **ecs:** remove unnecessary error when adding volume to external task definition ([#19774](#19774)) ([5446ded](5446ded)), closes [#19259](#19259) * **iam:** policies aren't minimized as far as possible ([#19764](#19764)) ([876ed8a](876ed8a)), closes [#19751](#19751) * **logs:** Faulty Resource Policy Generated ([#19640](#19640)) ([1fdf122](1fdf122)), closes [#17544](#17544)

Depends on cfnspec bump PR aws#19553 CFN Docs: https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-lambda-function-ephemeralstorage.html Blog: https://aws.amazon.com/blogs/aws/aws-lambda-now-supports-up-to-10-gb-ephemeral-storage/ <img width="1453" alt="image" src="https://user-images.githubusercontent.com/31543/160157013-1cc67553-60e7-461e-b90b-1e47d0d1215b.png"> Closes aws#19605. ---- ### All Submissions: * [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/master/INTEGRATION_TESTS.md)? * [ ] Did you use `cdk-integ` to deploy the infrastructure and generate the snapshot (i.e. `cdk-integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

github-actions bot added the @aws-cdk/aws-lambda Related to AWS Lambda label Mar 25, 2022

github-actions bot assigned kaizencc Mar 25, 2022

robertd added 2 commits March 25, 2022 08:06

feat(lambda): add support for ephemeral storage

3a70f66

add missing semicolon

5a5ea1b

robertd force-pushed the lambda-ephemeral-storage branch from 0a63ffb to 5a5ea1b Compare March 25, 2022 14:06

robertd added 4 commits March 25, 2022 08:42

throw on out of bound ephemeral storage size

986f671

update readme

2b8e85a

add tests

69a00ee

minor change

447ad15

robertd marked this pull request as ready for review March 25, 2022 15:26

kaizencc previously requested changes Mar 25, 2022

View reviewed changes

kaizencc added p1 feature-request A feature should be added or improved. effort/small Small work item – less than a day of effort labels Mar 25, 2022

Update packages/@aws-cdk/aws-lambda/lib/function.ts

ce255fd

Co-authored-by: Kaizen Conroy <[email protected]>

robertd and others added 4 commits March 25, 2022 15:30

Update packages/@aws-cdk/aws-lambda/lib/function.ts

3f58ab3

Co-authored-by: Kaizen Conroy <[email protected]>

Update packages/@aws-cdk/aws-lambda/test/function.test.ts

ef22c8f

Co-authored-by: Kaizen Conroy <[email protected]>

Update packages/@aws-cdk/aws-lambda/README.md

5227a3a

Co-authored-by: Kaizen Conroy <[email protected]>

Update packages/@aws-cdk/aws-lambda/lib/function.ts

39ed82d

Co-authored-by: Kaizen Conroy <[email protected]>

robertd added 3 commits March 25, 2022 17:14

fix few minor suggestions

f14691b

minor

e25f2d8

lint

617a4fe

madeline-k added the pr-linter/exempt-integ-test The PR linter will not require integ test changes label Mar 29, 2022

madeline-k previously requested changes Mar 29, 2022

View reviewed changes

packages/@aws-cdk/aws-lambda/lib/function.ts Outdated Show resolved Hide resolved

packages/@aws-cdk/aws-lambda/README.md Show resolved Hide resolved

packages/@aws-cdk/aws-lambda/test/function.test.ts Show resolved Hide resolved

madeline-k mentioned this pull request Mar 30, 2022

chore(aws-lambda): ephemeral storage support #19621

Closed

1 task

robertd and others added 2 commits March 30, 2022 09:10

fix rosetta

9d51de0

Merge branch 'master' into lambda-ephemeral-storage

b4172fb

rix0rrr previously requested changes Mar 31, 2022

View reviewed changes

packages/@aws-cdk/aws-lambda/lib/function.ts Outdated Show resolved Hide resolved

packages/@aws-cdk/aws-lambda/lib/function.ts Outdated Show resolved Hide resolved

github-actions bot added p1 and removed p2 labels Mar 31, 2022

makemefeelgr8 mentioned this pull request Mar 31, 2022

ec2: cross-app usage of VPC #4096

Closed

Update packages/@aws-cdk/aws-lambda/lib/function.ts

3cc1850

Co-authored-by: Rico Huijbers <[email protected]>

robertd and others added 7 commits March 31, 2022 08:52

Update packages/@aws-cdk/aws-lambda/lib/function.ts

be67334

Co-authored-by: Rico Huijbers <[email protected]>

Merge branch 'master' into lambda-ephemeral-storage

ced6336

Merge branch 'master' into lambda-ephemeral-storage

ffefc69

Merge branch 'master' into lambda-ephemeral-storage

3168256

Merge branch 'master' into lambda-ephemeral-storage

bdc6814

add test for token value

3f1fd81

Merge branch 'master' into lambda-ephemeral-storage

f0c5dd8

madeline-k approved these changes Apr 1, 2022

View reviewed changes

Merge branch 'master' into lambda-ephemeral-storage

0a4bde8

mergify bot merged commit f1d9b6a into aws:master Apr 1, 2022

robertd deleted the lambda-ephemeral-storage branch April 6, 2022 01:34

This was referenced Apr 7, 2022

chore(release): 1.152.0 #19781

Merged

chore(release): 2.20.0 #19801

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(lambda): add support for ephemeral storage #19552

feat(lambda): add support for ephemeral storage #19552

robertd commented Mar 25, 2022 •

edited by kaizencc

Loading

gitpod-io bot commented Mar 25, 2022

robertd commented Mar 25, 2022

kaizencc left a comment

robertd commented Mar 25, 2022

robertd commented Mar 28, 2022

madeline-k left a comment

robertd commented Apr 1, 2022

madeline-k left a comment

mergify bot commented Apr 1, 2022

aws-cdk-automation commented Apr 1, 2022

mergify bot commented Apr 1, 2022

khoatrandata commented Apr 6, 2022

robertd commented Apr 6, 2022

feat(lambda): add support for ephemeral storage #19552

feat(lambda): add support for ephemeral storage #19552

Conversation

robertd commented Mar 25, 2022 • edited by kaizencc Loading

All Submissions:

Adding new Unconventional Dependencies:

New Features

gitpod-io bot commented Mar 25, 2022

robertd commented Mar 25, 2022

kaizencc left a comment

Choose a reason for hiding this comment

robertd commented Mar 25, 2022

robertd commented Mar 28, 2022

madeline-k left a comment

Choose a reason for hiding this comment

robertd commented Apr 1, 2022

madeline-k left a comment

Choose a reason for hiding this comment

mergify bot commented Apr 1, 2022

aws-cdk-automation commented Apr 1, 2022

AWS CodeBuild CI Report

mergify bot commented Apr 1, 2022

khoatrandata commented Apr 6, 2022

robertd commented Apr 6, 2022

robertd commented Mar 25, 2022 •

edited by kaizencc

Loading