feat(batch): add secrets props to job definition #19506
Conversation
|
|
| @@ -112,6 +112,13 @@ export interface JobDefinitionContainer { | |||
| */ | |||
| readonly environment?: { [key: string]: string }; | |||
|
|
|||
| /** | |||
| * The environment variables from secrets manager or ssm parameter store | |||
There was a problem hiding this comment.
ecs.Secret will not support SSM parameter store though.
Don't you want core.SecretValue ?
There was a problem hiding this comment.
Well I guess not if you need the ARN. But in any case, the SSM comment here is inaccurate.
There was a problem hiding this comment.
To my understanding, ecs.Secret supports SSM parameter store through fromSsmParameter method.
Is it correct?
There was a problem hiding this comment.
Sorry, I was thinking of ssm.Secret.
|
@rix0rrr Anything else to be done here besides updating the comment? |
|
@rix0rrr What should I do next? This is my first OSS Contribution, please tell me. |
|
This PR has been in the MERGE CONFLICTS state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week. |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
This PR has been in the BUILD FAILING state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week. |
|
This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error. |
github-actions
bot
added
the
closed-for-staleness
Add a secrets property to batch.JobDefinitionContainer. This interface is almost the same as ecs.ContainerDefinitionOptions. This is reopen PR of #19506 closes #10976 ---- ### All Submissions: * [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [x] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)? * [x] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Add a secrets property to batch.JobDefinitionContainer. This interface is almost the same as ecs.ContainerDefinitionOptions. This is reopen PR of aws#19506 closes aws#10976 ---- ### All Submissions: * [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [x] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)? * [x] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
closes #10976
Add a
secretsproperty tobatch.JobDefinitionContainer. This interface is almost the same asecs.ContainerDefinitionOptions.