Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(cli): --no-notices not reflected in synth #19357

Closed
jaecktec opened this issue Mar 11, 2022 · 3 comments
Closed

(cli): --no-notices not reflected in synth #19357

jaecktec opened this issue Mar 11, 2022 · 3 comments
Labels
bug This issue is a bug. package/tools Related to AWS CDK Tools or CLI response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days.

Comments

@jaecktec
Copy link
Contributor

What is the problem?

When executing synth a call to cli.cdk.dev-tools.aws.dev is still being executed even though --no-notices was specified.
This causes builds in locked down environments to be super slow

Reproduction Steps

CDK_HOME=$(mktemp -d) NODE_DEBUG=http npx cdk synth --no-notices

What did you expect to happen?

log does not print

HTTP 65935: createConnection cli.cdk.dev-tools.aws.dev:443::::::::::::::::::::: 

so no connection was established

What actually happened?

log does print

HTTP 65935: createConnection cli.cdk.dev-tools.aws.dev:443::::::::::::::::::::: 

CDK CLI Version

2.15.0 (build 151055e)

Framework Version

No response

Node.js Version

2.15.0 (build 151055e)

OS

macos

Language

Typescript

Language Version

2.15.0 (build 151055e)

Other information

related to #19201

@jaecktec jaecktec added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Mar 11, 2022
@github-actions github-actions bot added the package/tools Related to AWS CDK Tools or CLI label Mar 11, 2022
@peterwoodworth
Copy link
Contributor

It seems to me that the PR that closed the issue you linked will resolve the issue you're experiencing once the next version comes out with that fix, since our latest version of v2 doesn't yet include that fix.

@peterwoodworth peterwoodworth removed the needs-triage This issue or PR still needs to be triaged. label Mar 11, 2022
@peterwoodworth peterwoodworth added the response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. label Mar 11, 2022
@jaecktec
Copy link
Contributor Author

jaecktec commented Mar 13, 2022

confirm it's fixed with 2.16.x

@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. package/tools Related to AWS CDK Tools or CLI response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days.
Projects
None yet
Development

No branches or pull requests

3 participants