Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(iotevents): create new module for IoT Events actions #18956

Merged
merged 7 commits into from
Feb 17, 2022
Merged

feat(iotevents): create new module for IoT Events actions #18956

merged 7 commits into from
Feb 17, 2022

Conversation

yamatatsu
Copy link
Contributor

This PR creates new module for aws-iotevents. This PR will contain implementations of Detector Model action classes.
About #18869 (comment) .

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Feb 12, 2022

@github-actions github-actions bot added the @aws-cdk/aws-iotevents Related to AWS IoT Events label Feb 12, 2022
skinny85
skinny85 previously approved these changes Feb 14, 2022
View reviewed changes
Copy link
Contributor

@skinny85 skinny85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yamatatsu!

skinny85
skinny85 reviewed Feb 14, 2022
View reviewed changes
packages/@aws-cdk/aws-iotevents-actions/package.json Outdated
"@aws-cdk/pkglint": "0.0.0",
"@types/jest": "^26.0.24",
"constructs": "^3.3.69",
"jest": "^26.6.3"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you want Jest in version "@types/jest": "^27.4.0" here - that should fix the build.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, maybe just remove Jest completely, and let the other tools bring it in. Look at how the other modules deal with it for reference.

@skinny85 skinny85 added the pr-linter/exempt-test The PR linter will not require test changes label Feb 14, 2022
@mergify mergify bot dismissed skinny85’s stale review February 15, 2022 12:51

Pull request has been modified.

@yamatatsu yamatatsu force-pushed the aws-iotevents-actions branch 2 times, most recently from 71c2901 to 281a317 Compare February 15, 2022 14:51
skinny85
skinny85 previously approved these changes Feb 16, 2022
View reviewed changes
Copy link
Contributor

@skinny85 skinny85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yamatatsu!

@mergify
Copy link
Contributor

mergify bot commented Feb 16, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@skinny85 skinny85 changed the title feat(iotevents): create new aws-iotevents-actions module feat(iotevents): create new module for IoT Events actions Feb 16, 2022
@mergify
Copy link
Contributor

mergify bot commented Feb 16, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot dismissed skinny85’s stale review February 17, 2022 02:15

Pull request has been modified.

@yamatatsu
Copy link
Contributor Author

Jest baseline version bumped up as ^27.4.7 -> ^27.5.1. So it was followed.

skinny85
skinny85 approved these changes Feb 17, 2022
View reviewed changes
Copy link
Contributor

@skinny85 skinny85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jest baseline version bumped up as ^27.4.7 -> ^27.5.1. So it was followed.

Pretty sure the minor version is taken from the lock file anyway, but thanks for the diligence 🙂.

@mergify
Copy link
Contributor

mergify bot commented Feb 17, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 4892208
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 3533ea9 into aws:master Feb 17, 2022
@mergify
Copy link
Contributor

mergify bot commented Feb 17, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@yamatatsu yamatatsu deleted the aws-iotevents-actions branch February 17, 2022 23:35
TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
@yamatatsu @TikiTDO
feat(iotevents): create new module for IoT Events actions (aws#18956)
855d354 
This PR creates new module for aws-iotevents. This PR will contain implementations of Detector Model action classes.
About aws#18869 (comment) .

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skinny85 skinny85 skinny85 approved these changes

Assignees

@skinny85 skinny85

Labels
@aws-cdk/aws-iotevents Related to AWS IoT Events pr-linter/exempt-test The PR linter will not require test changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yamatatsu @aws-cdk-automation @skinny85