Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(assert): support multiline strings with stringLike() #17692

Merged
merged 3 commits into from
Nov 25, 2021

Conversation

diegotry
Copy link
Contributor

Updates the RegExp constructor to support multiline. Resolves #17691


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Nov 24, 2021

@github-actions github-actions bot added the @aws-cdk/aws-appsync Related to AWS AppSync label Nov 24, 2021
@mergify
Copy link
Contributor

mergify bot commented Nov 24, 2021

Title does not follow the guidelines of Conventional Commits. Please adjust title before merge.

@diegotry diegotry changed the title Update stringLike to support multiline (fix) Update stringLike to support multiline Nov 24, 2021
@diegotry diegotry changed the title (fix) Update stringLike to support multiline fix: Update stringLike to support multiline Nov 24, 2021
@peterwoodworth peterwoodworth changed the title fix: Update stringLike to support multiline fix(assert): Update stringLike to support multiline Nov 24, 2021
@github-actions github-actions bot added the @aws-cdk/assert Related to the @aws-cdk/assert package label Nov 24, 2021
@peterwoodworth peterwoodworth removed the @aws-cdk/aws-appsync Related to AWS AppSync label Nov 24, 2021
@nija-at nija-at changed the title fix(assert): Update stringLike to support multiline fix(assert): support multiline strings with stringLike() Nov 25, 2021
@mergify
Copy link
Contributor

mergify bot commented Nov 25, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 6ead384
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 37596e6 into aws:master Nov 25, 2021
@mergify
Copy link
Contributor

mergify bot commented Nov 25, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

beezly pushed a commit to beezly/aws-cdk that referenced this pull request Nov 29, 2021
Updates the `RegExp` constructor to support multiline. Resolves aws#17691

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
Updates the `RegExp` constructor to support multiline. Resolves aws#17691

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/assert Related to the @aws-cdk/assert package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(assert-internal): stringLike function does not support multiline strings
5 participants