feat(iot): allow setting errorAction of TopicRule
#17287
Conversation
1. add properties `errorAction`
2. add tests
3. add lines to README
|
|
There was a problem hiding this comment.
Looks great @yamatatsu! Just a few tiny documentation changes.
packages/@aws-cdk/aws-iot/README.md
Outdated
| @@ -83,3 +99,5 @@ new iot.TopicRule(this, 'TopicRule', { | |||
| enabled: false, | |||
| }); | |||
| ``` | |||
|
|
|||
| See also [@aws-cdk/aws-iot-actions](https://github.com/aws/aws-cdk/blob/master/packages/%40aws-cdk/aws-iot-actions/README.md) for other actions. | |||
There was a problem hiding this comment.
Let's use a link to our API reference (https://docs.aws.amazon.com/cdk/api/latest/docs/aws-iot-actions-readme.html) instead of GitHub.
peterwoodworth
changed the title
errorAction of TopicRuleerrorAction of TopicRule
Co-authored-by: Adam Ruka <[email protected]>
Co-authored-by: Adam Ruka <[email protected]>
mergify
bot
dismissed
skinny85’s stale review
Pull request has been modified.
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
I'm trying to implement aws-iot L2 Constructs. This PR is one of steps after following PR: - aws#16681 (comment) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
I'm trying to implement aws-iot L2 Constructs.
This PR is one of steps after following PR:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license