Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for using ParameterMapping in LambdaProxyIntegration #17255

Closed
2 tasks
yip-anthony-principal opened this issue Nov 1, 2021 · 4 comments
Closed
2 tasks
Assignees
Labels
@aws-cdk/aws-apigatewayv2-integrations Related to AWS APIGatewayv2 Integrations feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged.

Comments

@yip-anthony-principal
Copy link

yip-anthony-principal commented Nov 1, 2021

Description

it seems the new ParameterMapping function only support HttpAlbIntegration. If I understand correctly it is not possible to add parameter mapping to LambdaProxyIntegration, if so is there any workaround for this?

Use Case

it's configurable on the AWS API Gateway website but not configurable on the AWS CDK

Proposed Solution

add support for it, like #15630

Other information

No response

Acknowledge

  • I may be able to implement this feature request
  • This feature might incur a breaking change
@yip-anthony-principal yip-anthony-principal added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Nov 1, 2021
@github-actions github-actions bot added the @aws-cdk/aws-apigatewayv2-integrations Related to AWS APIGatewayv2 Integrations label Nov 1, 2021
@dan-lind
Copy link
Contributor

dan-lind commented Nov 1, 2021

This shouldn't be a problem really, there are unit tests in place for LambdaProxyIntegration as well.

new LambdaProxyIntegration({
    handler: fooFunction(stack, 'Fn'),
    parameterMapping: new ParameterMapping()
      .appendHeader('header2', MappingValue.requestHeader('header1'))
      .removeHeader('header1'),
}),

@github-actions
Copy link

github-actions bot commented Nov 1, 2021

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@yip-anthony-principal
Copy link
Author

you are correct, thanks.

@github-actions
Copy link

github-actions bot commented Nov 1, 2021

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-apigatewayv2-integrations Related to AWS APIGatewayv2 Integrations feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged.
Projects
None yet
Development

No branches or pull requests

3 participants