Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create L2 for SSM #1257

Closed
RomainMuller opened this issue Nov 28, 2018 · 5 comments
Closed

Create L2 for SSM #1257

RomainMuller opened this issue Nov 28, 2018 · 5 comments
Assignees
Labels
closing-soon This issue will automatically close in 4 days unless further comments are made. feature-request A feature should be added or improved. pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member.

Comments

@RomainMuller
Copy link
Contributor

There is currently no L2 constructs for SSM.

@RomainMuller RomainMuller added the feature-request A feature should be added or improved. label Nov 28, 2018
@akkaash
Copy link

akkaash commented Dec 7, 2018

In case this isn't being actively worked upon, I can possibly take a stab at this over the weekend.

@rix0rrr
Copy link
Contributor

rix0rrr commented Dec 8, 2018

No one is working on this as far as I know.

@eladb
Copy link
Contributor

eladb commented Dec 9, 2018

That will be awesome @akkaash

Make sure you read our guidelines if you haven't already :-)

@akkaash
Copy link

akkaash commented Dec 21, 2018

Making progress here. I wanted to understand what's the stance on doing validation inside Constructs? Like for example, since TS only supports number which is floating point value and CFN spec expects an Integer type, is it safe to make these checks in the L2 constructs? I had the same concern in my PR #1221

I assume below (from guideline) applies in this case, need someone to confirm this though:

Good: Runtime check everything the type checker can’t enforce and fail early (error in the constructor).

@eladb
Copy link
Contributor

eladb commented Dec 24, 2018

Yes, you can add runtime checks in your L2s as you see fit, but I wouldn't over do it. For example, we usually don't verify that a number passed is an integer. The names of properties should be sufficiently clear for people not to make such mistakes, and if they do, they might get an error during deployment.

But generally, yes! runtime checks are good!

@NGL321 NGL321 added the closing-soon This issue will automatically close in 4 days unless further comments are made. label Sep 10, 2019
@NGL321 NGL321 added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Sep 10, 2019
@eladb eladb closed this as completed Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closing-soon This issue will automatically close in 4 days unless further comments are made. feature-request A feature should be added or improved. pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member.
Projects
None yet
Development

No branches or pull requests

5 participants