[aws-lambda-nodejs] 1.62.0 - fails to compile

[mbonig]

While trying to cdk synth a NodejsFunction construct, it errors:

unable to determine cloud assembly output directory. Assets must be defined indirectly within a "Stage" or an "App" scope

This problem does not exist if I rollback to 1.61.0

Reproduction Steps

Here is a repo that reproduces the problem:

https://github.com/mbonig/nodejs-fails-example

What did you expect to happen?

I expected the synth to work like it did in 1.61.0

What actually happened?

Got an error and the template failed to synth

Environment

• CLI Version : 1.62.0

• Framework Version: 1.62.0

• Node.js Version: v12.16.1

• OS : Distributor ID: LinuxMint
  Description: Linux Mint 19.3 Tricia
  Release: 19.3
  Codename: tricia

• Language (Version): Typescript

Other

---

This is 🐛 Bug Report

[jogold]

Are you sure all your modules are on 1.62.0?

[mbonig]

yes.

[jogold]

@mbonig this is an error from core when outdir cannot be determined. Does a "regular" Lambda function works? I suspect a problem with any construct using assets in your case.

[mbonig]

Works fine with a regular Function.

[jogold]

Works fine with a regular Function.

@mbonig I'm now able to reproduce. Very strange... on it.

This is almost exactly the same https://github.com/jogold/cdk-s3-thumbnail but it works on 1.62.0...

[jogold]

OK I found the issue 😄

For some unknown reason your package-lock.json contains incorrect nested cdk dependencies (see https://github.com/mbonig/nodejs-fails-example/pull/1/files for the diff which fixes it).

This leads to @aws-cdk/assets having another "copy" of @aws-cdk/core than the one used by @aws-cdk/aws-lambda-nodejs (the version is the same though):

I think that the multiple copies of @aws-cdk/core break all the Symbol.for/instanceof logic used by core to check if an App is an App:

aws-cdk/packages/@aws-cdk/core/lib/app.ts

Lines 83 to 85 in 287f808

	public static isApp(obj: any): obj is App {
	return APP_SYMBOL in obj;
	}

@mbonig how did you end up with this package-lock.json?

@eladb you should have a look at this. Issue should be renamed to something like multiple (nested) copies of @aws-cdk/core break the construct tree

[mbonig]

This was a very clean and basic new CDK module. So all I did to get here was a cdk init --language=typescript, an npm i and then started writing code and got errors...

[jogold]

This was a very clean and basic new CDK module. So all I did to get here was a cdk init --language=typescript, an npm i and then started writing code and got errors...

Which version of npm are you using?

I cannot reproduce this. I'm doing:

$ mkdir cdk-lock-file-test
$ cd cdk-lock-file-test
$ npx cdk init --language=typescript
$ npm i @aws-cdk/aws-lambda-nodejs

And then I don't have the nested @aws-cdk/core in @aws-cdk/assets

From this commit mbonig/nodejs-fails-example@25fd365 it looks like it happened during an update from 1.60.0 to 1.62.0.

[mbonig]

Looks like this comes from the bump-cdk tool I had used to upgrade the versions.

Closing this and reviewing the tool. Thanks!