fix(aws-logs): set default log retention of LogGroup to 731 instead o…

…f 730 (#1344) Fixes #1343
aws · Dec 13, 2018 · 71dc09f · 71dc09f
1 parent 48b9bdd
commit 71dc09f
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/packages/@aws-cdk/aws-logs/lib/log-group.ts b/packages/@aws-cdk/aws-logs/lib/log-group.ts
@@ -149,7 +149,7 @@ export interface LogGroupProps {
    *
    * To retain all logs, set this value to Infinity.
    *
-   * @default 730 days (2 years)
+   * @default 731 days (2 years)
    */
   retentionDays?: number;
 
@@ -184,7 +184,7 @@ export class LogGroup extends LogGroupRef {
     super(parent, id);
 
     let retentionInDays = props.retentionDays;
-    if (retentionInDays === undefined) { retentionInDays = 730; }
+    if (retentionInDays === undefined) { retentionInDays = 731; }
     if (retentionInDays === Infinity) { retentionInDays = undefined; }
 
     if (retentionInDays !== undefined && retentionInDays <= 0) {

diff --git a/packages/@aws-cdk/aws-logs/test/integ.metricfilter.lit.expected.json b/packages/@aws-cdk/aws-logs/test/integ.metricfilter.lit.expected.json
@@ -3,7 +3,7 @@
     "LogGroupF5B46931": {
       "Type": "AWS::Logs::LogGroup",
       "Properties": {
-        "RetentionInDays": 730
+        "RetentionInDays": 731
       }
     },
     "MetricFilter1B93B6E5": {

diff --git a/packages/@aws-cdk/aws-logs/test/test.loggroup.ts b/packages/@aws-cdk/aws-logs/test/test.loggroup.ts
@@ -31,7 +31,7 @@ export = {
 
     // THEN
     expect(stack).to(haveResource('AWS::Logs::LogGroup', {
-      RetentionInDays: 730
+      RetentionInDays: 731
     }));
 
     test.done();