Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppSync Merged API L2 construct #526

Closed
1 of 11 tasks
jumic opened this issue Jul 31, 2023 · 3 comments
Closed
1 of 11 tasks

AppSync Merged API L2 construct #526

jumic opened this issue Jul 31, 2023 · 3 comments

Comments

@jumic
Copy link

jumic commented Jul 31, 2023

Description

This RFC proposes a new L2 construct to support AppSync Merged APIs. Merged APIs can be used to combine multiple AppSync source APIs into a single (merged) AppSync API.

Compared to the existing AppSync GraphqlApi, a merged API has different attributes. The schema attribute is mandatory for GraphQL APIs. It doesn't exist for merged APIs. So it's necessary to create a new construct to support Merged APIs.

I have also created a feature request for initial discussions on this topic: aws/aws-cdk#25960

Roles

Role User
Proposed by @jumic
Author(s) @jumic
API Bar Raiser
Stakeholders

See RFC Process for details

Workflow

  • Tracking issue created (label: status/proposed)
  • API bar raiser assigned (ping us at #aws-cdk-rfcs if needed)
  • Kick off meeting
  • RFC pull request submitted (label: status/review)
  • Community reach out (via Slack and/or Twitter)
  • API signed-off (label api-approved applied to pull request)
  • Final comments period (label: status/final-comments-period)
  • Approved and merged (label: status/approved)
  • Execution plan submitted (label: status/planning)
  • Plan approved and merged (label: status/implementing)
  • Implementation complete (label: status/done)

Author is responsible to progress the RFC according to this checklist, and
apply the relevant labels to this issue so that the RFC table in README gets
updated.

@rix0rrr
Copy link
Contributor

rix0rrr commented Aug 10, 2023

We talked during the Office Hours, and we agreed that this change should be small enough that it doesn't need a full RFC.

We will deprecate the schema: ISchema in favor of a new field that will be typed as an enum-like class, to decide between a schema-based API or a merged API.

@evgenyka evgenyka added l2-request request for new L2 construct bar-raiser/needed labels Aug 10, 2023
@jumic
Copy link
Author

jumic commented Aug 26, 2023

I implemented a solution without new L2 construct: aws/aws-cdk#26895
So let's close this RFC issue.
@rix0rrr Thanks for our help!

@jumic jumic closed this as completed Aug 26, 2023
@mrgrain mrgrain added status/rejected and removed status/proposed Newly proposed RFC labels Nov 1, 2023
@mrgrain
Copy link
Contributor

mrgrain commented Nov 1, 2023

We went down a different route than this RFC had proposed.

@mrgrain mrgrain closed this as not planned Won't fix, can't repro, duplicate, stale Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants