Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stateful resource support #23

Closed
1 of 12 tasks
eladb opened this issue Dec 8, 2019 · 2 comments
Closed
1 of 12 tasks

Stateful resource support #23

eladb opened this issue Dec 8, 2019 · 2 comments
Labels
framework status/stale The RFC did not get any significant enough progress or tracking and has become stale.

Comments

@eladb
Copy link
Contributor

eladb commented Dec 8, 2019

PR Champion
#

Description

  • Identifying L2s as stateful resource
  • Default removal policy
  • Automatic stack policy for protecting resources
  • Related to traffic shifting
  • Related to imports

Progress

  • Tracking Issue Created
  • RFC PR Created
  • Core Team Member Assigned
  • Initial Approval / Final Comment Period
  • Ready For Implementation
    • implementation issue 1
  • Resolved
@eladb eladb changed the title Resource import Stateful resource support Dec 8, 2019
@eladb eladb added the framework label Dec 8, 2019
@MrArnoldPalmer MrArnoldPalmer added the status/proposed Newly proposed RFC label Jan 4, 2020
@eladb eladb mentioned this issue Jan 23, 2020
6 tasks
@eladb
Copy link
Contributor Author

eladb commented Jan 23, 2020

From #76:

  • Add stateful: boolean to cdk.IResource
  • Refactor RemovalPolicy to an enum-like and move apply to there
  • Consider how/if we should model statefulness in L1 considering AWS Resource Model #73
  • Implement and apply rule awslint:state-annotation: All resource classes should be marked with "@stateful" or "@stateless"
  • Implement and apply rule awslint:state-removal-policy-prop: All stateful resource should have a "removalPolicy" prop
  • Implement and apply rule awslint:state-stateful-property: All resources should have a "stateful" property returns true/false

@mrgrain
Copy link
Contributor

mrgrain commented Oct 27, 2023

Already exists in a basic form. Unclear what more is proposed.

Marking this RFCs as stale since there has been little recent activity and it is not currently close to getting accepted as-is. We appreciate the effort that has gone into this proposal. Marking an RFCs as stale is not a one-way door. If you have made substantial changes to the proposal, please open a new issue/RFC. You might also consider raising a PR to aws/aws-cdk directly or self-publishing to Construct Hub.

@mrgrain mrgrain closed this as not planned Won't fix, can't repro, duplicate, stale Oct 27, 2023
@mrgrain mrgrain added status/stale The RFC did not get any significant enough progress or tracking and has become stale. and removed status/proposed Newly proposed RFC labels Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
framework status/stale The RFC did not get any significant enough progress or tracking and has become stale.
Projects
None yet
Development

No branches or pull requests

3 participants