Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Rate Limiting #107

Open
bcelenza opened this issue Sep 13, 2019 · 12 comments
Open

Feature Request: Rate Limiting #107

bcelenza opened this issue Sep 13, 2019 · 12 comments
Assignees
Labels
Roadmap: Accepted We are planning on doing this work.

Comments

@bcelenza
Copy link
Contributor

bcelenza commented Sep 13, 2019

Tell us about your request
App Mesh should support the ability to configure rate limiting for requests coming into or out of a Virtual Node. This could be enabled by using Envoy Proxy's Global Rate Limiting. With this setting, customers could define thresholds for how many transactions (i.e. requests) per time period to allow from a given caller before throttling further traffic.

This is similar to #6 (Circuit Breaker Policy) but solves additional use cases depending on the traffic characteristics being handled by the service.

Which integration(s) is this request for?
All

Tell us about the problem you're trying to solve. What are you trying to do, and why is it hard?

  1. Given a known set of clients calling my service, I would like to limit the amount of requests-per-second they may send before I fail the request with an error code, letting them know they have exceeded their rate limits.
  2. Given a known egress destination, I would like to limit the amount of requests-per-second I send to the destination to keep from overwhelming them, in the case that they cannot rate limit me on the server side.
@bcelenza bcelenza added the Roadmap: Proposed We are considering this for inclusion in the roadmap. label Sep 13, 2019
@jamsajones jamsajones added the Roadmap: Accepted We are planning on doing this work. label Sep 26, 2019
@shubharao shubharao removed the Roadmap: Proposed We are considering this for inclusion in the roadmap. label Sep 26, 2019
@isaac-mj
Copy link

isaac-mj commented Jun 1, 2020

Hi @shubharao, I've noticed that this feature request has been accepted but it's not in the roadmap project --> https://github.com/aws/aws-app-mesh-roadmap/projects/1

Any ideas of when you guys will start working on ti?

@bcelenza
Copy link
Contributor Author

bcelenza commented Jun 3, 2020

Hey @isaac-mj , fixed that. It is on our roadmap, but we're not actively working on it at the moment.

Is this one of interest to you? Have any requirements or thoughts you could share on what you'd want if so? :)

@amanullah92
Copy link

When using Virtual Gateway as the Ingress, having API rate limiting is a very natural requirement since it's not fulfilled by NLB/ALB either. I really don't want to integrate WAF for the purpose, since in many cases calls come from internal services residing in another data centre or cloud provider.

@herrhound herrhound assigned herrhound and unassigned shubharao Apr 30, 2021
@ghost
Copy link

ghost commented May 25, 2021

I am also interested in this. I will probably be potentially implementing this in the coming months. Is there any way to inject arbitrary envoy config into appMesh config? I see something like that for stats and tracing, but nothing else.

Thanks

@jjacob27
Copy link

We are also not interested in rate limiting.

@alexbricepalo
Copy link

+1

@herrhound
Copy link
Contributor

@koresar, App Mesh does not configure any rate limitation for Envoy proxies, at does not allow for custom configuration of rate limiting at the moment. Please open a support case with the details of your environment / configuration and error logs, so our team can look into it.

@koresar
Copy link

koresar commented Feb 2, 2022

Thanks @herrhound
Apologies.
I confused rate limiting with something else.

@amazkovoi
Copy link

+1 - Would be fantastic if this was added!

@recreational-snacker
Copy link

+1, this would be cool!

@karanb192
Copy link

+1 - much needed feature and other service mesh alternatives like Istio already support it.

@simano65
Copy link

+1 - any updates on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Roadmap: Accepted We are planning on doing this work.
Projects
None yet
Development

No branches or pull requests