Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add parameter for x-ray sidecar image #287

Closed
rafaelpereyra opened this issue May 6, 2020 · 2 comments
Closed

Add parameter for x-ray sidecar image #287

rafaelpereyra opened this issue May 6, 2020 · 2 comments
Assignees
@fawadkhaliq @astrived
Labels
enhancement New feature or request
Milestone
1.1.1

Comments

@rafaelpereyra
Copy link

Hello,

When dealing with a single source of truth for the Image repository (Single shared ECR account for example), it's important to be able to specify the images to be deployed on each environment.

The injector currently allows to specify the images for:

  • Injector
  • Envoy
  • Proxy-route-manager

However for the X-Ray image it uses a fixed github repo defined in xrayDaemonContainerTemplate.

The injection of the X-Ray sidecar is very useful and provides an easy integration path between both services (App-Mesh / X-Ray) so it will be very useful to have this additional parameter so there is no need to load the sidecar manually and leave the default repo as default value just like the other images.
@rafaelpereyra rafaelpereyra changed the title Add parameter for x-ray sidecar Add parameter for x-ray sidecar image May 6, 2020
@achevuru achevuru transferred this issue from amazon-archives/aws-app-mesh-inject Jun 18, 2020
@M00nF1sh
Copy link
Contributor

we should expose a configurability for this

@M00nF1sh M00nF1sh added the enhancement New feature or request label Jun 18, 2020
@astrived astrived added this to the 1.1.1 milestone Jun 29, 2020
cmdallas added a commit to cmdallas/aws-app-mesh-controller-for-k8s that referenced this issue Jul 14, 2020
@cmdallas
feat(inject): expose configuration for x-ray sidecar image (aws#287)
f8dca9e
cmdallas added a commit to cmdallas/eks-charts that referenced this issue Jul 14, 2020
@cmdallas
feat(appmesh-controller): add support for configuring xray image
68ae84e 
aws/aws-app-mesh-controller-for-k8s#287
cmdallas added a commit to cmdallas/eks-charts that referenced this issue Jul 14, 2020
@cmdallas
feat(appmesh-controller): add support for configuring xray image
c7eac84 
aws/aws-app-mesh-controller-for-k8s#287
@cmdallas cmdallas mentioned this issue Jul 14, 2020
Merged
fawadkhaliq pushed a commit that referenced this issue Jul 16, 2020
@cmdallas
feat(inject): expose configuration for x-ray sidecar image (#287) (#313)
342cd61
@fawadkhaliq
Copy link

x-ray sidecar image is configurable now #313 thanks @cmdallas

cmdallas added a commit to cmdallas/eks-charts that referenced this issue Jul 16, 2020
@cmdallas
feat(appmesh-controller): add support for configuring xray image
7c91e11 
aws/aws-app-mesh-controller-for-k8s#287
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fawadkhaliq fawadkhaliq

@astrived astrived

Labels
enhancement New feature or request
Projects
None yet
Milestone
1.1.1
Development

No branches or pull requests
4 participants
@fawadkhaliq @rafaelpereyra @M00nF1sh @astrived